Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of httpx as a test dependency #7950

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Drop use of httpx as a test dependency #7950

merged 1 commit into from
Oct 31, 2024

Conversation

msullivan
Copy link
Member

We only use it in one test and are getting rid of it as a real
dependency (see #7927), so let's just drop it.

Copy link
Contributor

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- just needs the pyproject.toml changes

We only use it in one test and are getting rid of it as a real
dependency, so let's just drop it.
@msullivan msullivan merged commit 3877b6b into master Oct 31, 2024
23 checks passed
@msullivan msullivan deleted the no-test-httpx branch October 31, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants