Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full http in Rust support, remove httpx #7927

Merged
merged 17 commits into from
Oct 31, 2024
Merged

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Oct 25, 2024

Makes use of HttpClient throughout the entire server process:

  • Auth
  • AI extension (incl. SSE)
  • std::net::http

Notes:

  • httpx is no longer a dep (kept as a dev-dependency)
  • Uses an EdgeDB ${version} User-Agent for all HTTP requests
  • All HTTP requests are subject to http_max_connections config option. This option is refreshed from the std::net worker.
  • SSE supports backpressure, and queue is fixed at 100 messages for now
  • Streaming and non-streaming requests use separate APIs to simplify the implementation
  • One thread per tenant is used if HTTP is required (we boot this thread only when needed). Eventually we'll move to a one-runtime-per-tenant and this thread will disappear.

@mmastrac mmastrac changed the title WIP: full http in Rust support Full http in Rust support, remove httpx Oct 29, 2024
@mmastrac mmastrac marked this pull request as ready for review October 29, 2024 18:01
@msullivan
Copy link
Member

msullivan commented Oct 31, 2024

I decided to go get rid of httpx as a test dependency too: #7950

@mmastrac mmastrac merged commit 63e6fc4 into geldata:master Oct 31, 2024
23 checks passed
msullivan added a commit that referenced this pull request Oct 31, 2024
We only use it in one test and are getting rid of it as a real
dependency (see #7927), so let's just drop it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants