Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factoring of columns in USING clause over SQL adapter #7923

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Factoring of columns in USING clause over SQL adapter #7923

merged 4 commits into from
Oct 30, 2024

Conversation

aljazerzen
Copy link
Contributor

@aljazerzen aljazerzen commented Oct 25, 2024 •
edited
Loading

This PR makes the last id identifier in this query:

SELECT
FROM x
JOIN y USING (id)
WHERE id = 4  -- this id is not ambiguous

... not ambiguous, but instead equivalent to x.id.

@aljazerzen aljazerzen mentioned this pull request Oct 25, 2024
Open
6 tasks
msullivan
msullivan approved these changes Oct 29, 2024
View reviewed changes
@aljazerzen aljazerzen merged commit 876ac76 into master Oct 30, 2024
23 checks passed
@aljazerzen aljazerzen deleted the sql-join-ambigious branch October 30, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elprans elprans elprans approved these changes

@msullivan msullivan msullivan approved these changes

@vpetrovykh vpetrovykh Awaiting requested review from vpetrovykh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljazerzen @msullivan @elprans