Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of SQL introspection #7922

Open
5 of 6 tasks
aljazerzen opened this issue Oct 25, 2024 · 1 comment
Open
5 of 6 tasks

Improvements of SQL introspection #7922

aljazerzen opened this issue Oct 25, 2024 · 1 comment
Labels

Comments

@aljazerzen
Copy link
Contributor

aljazerzen commented Oct 25, 2024

Currently, introspection over SQL adapter is a bit lacking. In some cases, we leak internal database structure that should not be visible to end users (i.e. schema edgedbpub) and in some cases we don't expose features because they don't exist in the internal database (foreign keys).

This issue is a tracking issue of all such problems:

@aljazerzen aljazerzen added the sql label Oct 25, 2024
@aljazerzen
Copy link
Contributor Author

aljazerzen commented Oct 25, 2024

We also need to decide on which schemas to expose. Currently, this is what is seen in an empty database:

pg_toast                -- PostgreSQL
pg_catalog              -- PostgreSQL
information_schema      -- PostgreSQL

edgedb_v6_2f209700f0    -- for module schema::
edgedb                  -- for module schema::, trampolined

edgedbstd_v6_2f209700f0 -- for module std::
edgedbstd               -- for module std::, trampolined

edgedbt 				-- for datetime types in std::

public                  -- for module default

I think we should:

  • hide all trampolined schemas,
  • rename edgedb into schema,
  • rename edgedbstd into std,
  • merge edgedbt into std.

Edit: where should we put types without edgedb module? Things like tuple<str, int64>? Currently, they appear in public, which might be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant