Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDGEDB_TEST_REPEATS env var for testing function cache #7497

Merged
merged 8 commits into from
Jul 16, 2024
+120 −31
Merged

Add EDGEDB_TEST_REPEATS env var for testing function cache #7497

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
87062ad
Add EDGEDB_TEST_REPEATS env var for testing function cache
msullivan Jun 26, 2024
46fa7d5
Resolve the issue returning tuple
fantix Jul 5, 2024
104204d
Merge remote-tracking branch 'origin/master' into func-cache-testing
fantix Jul 10, 2024
3a5be70
Fix muted exception issue when output_format=None
fantix Jul 10, 2024
05f2d4e
Fix tests to support repeating
fantix Jul 10, 2024
bcd03a6
Enable EDGEDB_TEST_REPEATS in CI
fantix Jul 10, 2024
cd1857f
Merge remote-tracking branch 'origin/master' into func-cache-testing
fantix Jul 16, 2024
ac53d24
Fix more tests in test_protocol
fantix Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion edb/testbase/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,14 @@ def _iter_methods(bases, ns):
yield methname, meth

@classmethod
def wrap(mcls, meth):
def wrap(mcls, meth, is_repeat=False):
@functools.wraps(meth)
def wrapper(self, *args, __meth__=meth, **kwargs):
try_no = 1

if is_repeat and not getattr(self, 'TRANSACTION_ISOLATION', False):
raise unittest.SkipTest()

while True:
try:
# There might be unobvious serializability
Expand Down Expand Up @@ -216,6 +219,16 @@ def wrapper(self, *args, __meth__=meth, **kwargs):
def add_method(mcls, methname, ns, meth):
ns[methname] = mcls.wrap(meth)

# If EDGEDB_TEST_REPEATS is set, duplicate all the tests.
# This is valuable because it should exercise the function
# cache.
if (
os.environ.get('EDGEDB_TEST_REPEATS', None)
and methname.startswith('test_')
):
new = methname.replace('test_', 'test_zREPEAT_', 1)
ns[new] = mcls.wrap(meth, is_repeat=True)

def __new__(mcls, name, bases, ns):
for methname, meth in mcls._iter_methods(bases, ns.copy()):
if methname in ns:
Expand Down