Add EDGEDB_TEST_REPEATS env var for testing function cache #7497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When EDGEDB_TEST_REPEATS is set, the test suite duplicates transactional query tests, and the re-run version will typically use the function cache. There are some actual failures when I ran this that need to be investigated.
elprans
approved these changes
Jun 27, 2024
This issue only happens with binary output format, executing query like:
select ((insert A), true);
The fix is simply applying the returns_record fix to tuples:
070d74c#diff-d2fc37bc724ef58ac44d52da73c773483ba90dd9818f3acede2664abd700e850R1925-R1951
fantix
force-pushed
the
func-cache-testing
branch
from
3164b5a to
63cabc4
Compare
* test_proto_parse_cardinality() * test_proto_state_change_in_tx() * test_edgeql_insert_default_05() * test_edgeql_dt_sequence_01()
fantix
force-pushed
the
func-cache-testing
branch
from
53fc30c to
cd1857f
Compare
...in a new way to tear down created fixtures
|
Changes look good. I can't mark "approved" because github thinks of me as the author, but let's merge |
2 tasks
aljazerzen
pushed a commit
that referenced
this pull request
Oct 23, 2024
When EDGEDB_TEST_REPEATS is set, the test suite duplicates
transactional query tests, and the re-run version will typically use
the function cache.
There are some actual failures when I ran this that need to be
investigated.
Also resolve the issue returning tuple that only happens with
binary output format, executing query like:
select ((insert A), true);
The fix is simply applying the returns_record fix to tuples:
070d74c#diff-d2fc37bc724ef58ac44d52da73c773483ba90dd9818f3acede2664abd700e850R1925-R1951
---------
Co-authored-by: Fantix King <[email protected]>
aljazerzen
added
the
backported-5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When EDGEDB_TEST_REPEATS is set, the test suite duplicates
transactional query tests, and the re-run version will typically use
the function cache.
There are some actual failures when I ran this that need to be
investigated.