Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve /metrics by tenant #7024

Merged
merged 1 commit into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 55 additions & 8 deletions edb/common/prometheus.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,10 @@ def new_labeled_histogram(
self._add_metric(hist)
return hist

def generate(self) -> str:
def generate(self, **label_filters: str) -> str:
buffer: list[str] = []
for metric in self._metrics:
metric._generate(buffer)
metric._generate(buffer, **label_filters)
buffer.append('')
return '\n'.join(buffer)

Expand Down Expand Up @@ -286,7 +286,31 @@ def _validate_label_values(
if not val:
raise ValueError(f'empty value for label {name!r}')

def _generate(self, buffer: list[str]) -> None:
def _make_label_filter(
self,
labels: tuple[str, ...],
label_filters: dict[str, str],
) -> typing.Callable[[tuple[str, ...]], bool]:
if not label_filters:
return lambda _: True

try:
label_by_idx = [
(labels.index(label), label_val)
for label, label_val in label_filters.items()
]
except ValueError:
return lambda _: False

def label_filter(label_values: tuple[str, ...]) -> bool:
for idx, label_val in label_by_idx:
if label_values[idx] != label_val:
return False
return True

return label_filter

def _generate(self, buffer: list[str], **label_filters: str) -> None:
raise NotImplementedError


Expand All @@ -308,7 +332,10 @@ def __init__(
self._validate_label_names(tuple(labels.keys()))
self._labels = labels

def _generate(self, buffer: list[str]) -> None:
def _generate(self, buffer: list[str], **label_filters: str) -> None:
if label_filters:
return

desc = _format_desc(self._desc)

buffer.append(f'# HELP {self._name}_info {desc}')
Expand Down Expand Up @@ -340,7 +367,10 @@ def inc(self, value: float = 1.0) -> None:
'counter cannot be incremented with a negative value')
self._value += value

def _generate(self, buffer: list[str]) -> None:
def _generate(self, buffer: list[str], **label_filters: str) -> None:
if label_filters:
return

desc = _format_desc(self._desc)

buffer.append(f'# HELP {self._name}{self._suffix} {desc}')
Expand Down Expand Up @@ -382,16 +412,20 @@ def inc(self, value: float = 1.0, *labels: str) -> None:
self._metric_values[labels] = value
self._metric_created[labels] = self._registry.now()

def _generate(self, buffer: list[str]) -> None:
def _generate(self, buffer: list[str], **label_filters: str) -> None:
desc = _format_desc(self._desc)

buffer.append(f'# HELP {self._name}{self._suffix} {desc}')
buffer.append(f'# TYPE {self._name}{self._suffix} {self._type}')

filter_func = self._make_label_filter(self._labels, label_filters)
for labels, value in self._metric_values.items():
if not filter_func(labels):
continue
fmt_label = ','.join(
f'{label}="{_format_label_val(label_val)}"'
for label, label_val in zip(self._labels, labels)
if label not in label_filters
)
buffer.append(
f'{self._name}{self._suffix}{{{fmt_label}}} {float(value)}'
Expand All @@ -402,9 +436,12 @@ def _generate(self, buffer: list[str]) -> None:
buffer.append(f'# TYPE {self._name}_created gauge')

for labels, value in self._metric_created.items():
if not filter_func(labels):
continue
fmt_label = ','.join(
f'{label}="{_format_label_val(label_val)}"'
for label, label_val in zip(self._labels, labels)
if label not in label_filters
)
buffer.append(
f'{self._name}_created{{{fmt_label}}} {float(value)}'
Expand Down Expand Up @@ -526,7 +563,10 @@ def observe(self, value: float) -> None:
self._values[idx] += 1.0
self._sum += value

def _generate(self, buffer: list[str]) -> None:
def _generate(self, buffer: list[str], **label_filters: str) -> None:
if label_filters:
return

desc = _format_desc(self._desc)

buffer.append(f'# HELP {self._name} {desc}')
Expand Down Expand Up @@ -585,16 +625,20 @@ def observe(self, value: float, *labels: str) -> None:
metric[1][idx] += 1.0 # type: ignore
metric[0] += value # type: ignore

def _generate(self, buffer: list[str]) -> None:
def _generate(self, buffer: list[str], **label_filters: str) -> None:
desc = _format_desc(self._desc)

buffer.append(f'# HELP {self._name} {desc}')
buffer.append(f'# TYPE {self._name} histogram')

filter_func = self._make_label_filter(self._labels, label_filters)
for labels, values in self._metric_values.items():
if not filter_func(labels):
continue
fmt_label = ','.join(
f'{label}="{_format_label_val(label_val)}"'
for label, label_val in zip(self._labels, labels)
if label not in label_filters
)
accum = 0.0
for buck, val in zip(self._buckets, values[1]): # type: ignore
Expand All @@ -619,9 +663,12 @@ def _generate(self, buffer: list[str]) -> None:
buffer.append(f'# HELP {self._name}_created {desc}')
buffer.append(f'# TYPE {self._name}_created gauge')
for labels, value in self._metric_created.items():
if not filter_func(labels):
continue
fmt_label = ','.join(
f'{label}="{_format_label_val(label_val)}"'
for label, label_val in zip(self._labels, labels)
if label not in label_filters
)
buffer.append(
f'{self._name}_created{{{fmt_label}}} {float(value)}'
Expand Down
8 changes: 7 additions & 1 deletion edb/server/protocol/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,15 @@
async def handle_request(
request,
response,
tenant,
):
try:
output = metrics.registry.generate()
if tenant is None:
output = metrics.registry.generate()
else:
output = metrics.registry.generate(
tenant=tenant.get_instance_name()
)
response.status = http.HTTPStatus.OK
response.content_type = b'text/plain; version=0.0.4; charset=utf-8'
response.body = output.encode()
Expand Down
1 change: 1 addition & 0 deletions edb/server/protocol/protocol.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,7 @@ cdef class HttpProtocol:
await metrics.handle_request(
request,
response,
self.tenant,
)
elif (path_parts == ['server-info'] and
request.method == b'GET' and
Expand Down
Loading