Lock concurrent compiles of the same query #6349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
force-pushed
the
locked-compile
branch
3 times, most recently
from
6928bfd to
ba8d579
Compare
msullivan
added a commit
that referenced
this pull request
Mar 1, 2024
We don't need to query or set __internal_testmode in order to create a database from a template anymore. Clean up that code. This will also fix a flake, probably, but we *are* planning to fix it more properly (see #6349).
msullivan
added a commit
that referenced
this pull request
Mar 1, 2024
We don't need to query or set __internal_testmode in order to create a database from a template anymore. Clean up that code. This will also fix a flake, probably, but we *are* planning to fix it more properly (see #6349).
We cannot use a Future in the LRU mapping, because we don't want to invalidate an old cache item if the new compile result turns to be not cacheable; and we can only know such thing after the compilation.
msullivan
approved these changes
Mar 4, 2024
msullivan
added a commit
that referenced
this pull request
Mar 7, 2024
We don't need to query or set __internal_testmode in order to create a database from a template anymore. Clean up that code. This will also fix a flake, probably, but we *are* planning to fix it more properly (see #6349).
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
We cannot use a Future in the LRU mapping, because we don't want to invalidate an old cache item if the new compile result turns to be not cacheable; and we can only know such thing after the compilation.
msullivan
added a commit
that referenced
this pull request
Mar 7, 2024
We don't need to query or set __internal_testmode in order to create a database from a template anymore. Clean up that code. This will also fix a flake, probably, but we *are* planning to fix it more properly (see #6349).
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
We cannot use a Future in the LRU mapping, because we don't want to invalidate an old cache item if the new compile result turns to be not cacheable; and we can only know such thing after the compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent compile requests of the same query (against the same dbver) should only be processed once.
Details are explained in each commit message.