Persistent cache #6589
Closed
Persistent cache #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries after DDL in a transaction have been running without cache for some time, dropping the dead code for now; maybe we will add it back in the future properly.
During a query compilation, if the schema is changed, the server was caching the compiled query under a wrong dbver, causing future queries to fail. See the test for issue reproduction.
fantix
force-pushed
the
persistent-cache
branch
3 times, most recently
from
d184c52 to
f617fe1
Compare
fantix
force-pushed
the
persistent-cache
branch
from
f617fe1 to
2e2341a
Compare
fantix
force-pushed
the
persistent-cache
branch
from
22e1993 to
2936ae1
Compare
1st1
reviewed
Dec 20, 2023
| @@ -535,7 +535,13 @@ cdef class DatabaseConnectionView: | |||
| raise errors.InternalServerError( | |||
| 'no need to serialize state while in transaction') | |||
|
|
|||
| ver = self._db.schema_version | |||
| ver = hash( | |||
There was a problem hiding this comment.
Will ver ever end up in Postgres or in another Python process? hash() as you know is randomized
There was a problem hiding this comment.
Negative. In Postgres, it's in the state temporary table and never used.
fantix
force-pushed
the
persistent-cache
branch
2 times, most recently
from
15a04d4 to
83f17ec
Compare
fantix
force-pushed
the
persistent-cache
branch
from
83f17ec to
e3545ca
Compare
fantix
force-pushed
the
persistent-cache
branch
from
f6175f0 to
064d99f
Compare
|
Close in favor of #6881 and many others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6349
Add LRUMapping.gc()we can usestmt_cache.pyxdbverwith the non-local schema version