Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA27 - Remove the commit trigger on main #220

Merged
merged 1 commit into from
May 2, 2024

Conversation

daniycity
Copy link
Contributor

Hello, I'm pretty stupid so please double check 👍
I've removed
push: branches: [main]
On file for github actions:

  • axe.yml
  • lighthouse.yml
  • playwright.yml
  • test-firebase-functions.yml (I think we should rename this one)
  • vitest.yml

Copy link

github-actions bot commented May 2, 2024

Playwright test results

passed  3 passed

Details

stats  3 tests across 1 suite
duration  6.4 seconds
commit  dcc667f

Copy link

github-actions bot commented May 2, 2024

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

Lighthouse ran against http://localhost:4321/

@gregoriopalama gregoriopalama self-requested a review May 2, 2024 21:26
@gregoriopalama
Copy link
Member

Looks good to me, great first issue @daniycity !

Closes #219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants