Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFRA27 - Remove the commit trigger from workflows used for checks #219

Closed
gregoriopalama opened this issue Apr 30, 2024 · 1 comment
Closed

INFRA27 - Remove the commit trigger from workflows used for checks #219

gregoriopalama opened this issue Apr 30, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task This is a Task. Contributors can work on this

Comments

@gregoriopalama
Copy link
Member

Remove the commit trigger (actually on main) from axe, vitest, lighthouse, playwright and firebase functions test workflows.

As for now, it is not needed. It will fail, because we are using pull_request_target too and we need to checkout from the pr's commit hash. Also, we are using PRs, so no commits should be done on main directly.
@gregoriopalama gregoriopalama added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task This is a Task. Contributors can work on this labels Apr 30, 2024
@gregoriopalama gregoriopalama mentioned this issue May 2, 2024
Merged
@gregoriopalama
Copy link
Member Author

Closed by #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task This is a Task. Contributors can work on this
Projects
Hedwig
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregoriopalama