Issue 2875 - System test Rust compaction #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtjd6554
reviewed
Aug 7, 2024
| private CompactionRunner createRunnerForMethod(CompactionMethod method) { | ||
| switch (method) { | ||
| case RUST: | ||
| return new RustCompaction(tablePropertiesProvider, stateStoreProvider); |
There was a problem hiding this comment.
Is there any scenario where we'd need to create the RustCompaction outside this method in the future, if so moving it out to a separate private method like the java runner might be worth it
There was a problem hiding this comment.
I think that'd be easy enough that there's no reason to do it now, unless it'd actually read better?
There was a problem hiding this comment.
Was just a note for future ideas, approved as it was fine without
rtjd6554
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.
NOTICES file to reflect this.