Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate optional stacks #3296

Merged
merged 23 commits into from
Sep 18, 2024
Merged

Validate optional stacks #3296

merged 23 commits into from
Sep 18, 2024

Conversation

rtjd6554
Copy link
Collaborator

@rtjd6554 rtjd6554 commented Sep 17, 2024 •
edited by patchwork01
Loading

Make sure you have checked all steps below.

Issue

  • My PR addresses the following issues and references them in the PR title. For example, "Issue 1234 - My Sleeper
    PR"

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • OptionalStackTest

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

@rtjd6554 rtjd6554 linked an issue Sep 17, 2024 that may be closed by this pull request
Validate optional stacks #3204
Closed
@rtjd6554 rtjd6554 changed the base branch from develop to 3195-default-reservedmax-concurrency-for-lambdas-scaling-across-sleeper-tables September 17, 2024 09:12
@rtjd6554 rtjd6554 force-pushed the 3204-validate-optional-stacks branch from f821727 to b9d1946 Compare September 17, 2024 09:19
rtjd6554 and others added 19 commits September 17, 2024 10:42
@rtjd6554
Generation of OptionalStack class and defaultValue test
341bee3
@patchwork01
Validate optional stacks
eb7a7f9
@patchwork01
Use SleeperPropertyValues.readList for validation
00d46ed
@patchwork01
Use OptionalStack enum in CDK
456334b
@rtjd6554
Fix for compilatin error
e86b219
@rtjd6554
Update for SystemTestInstance usage of enum
d1e5abe
@rtjd6554
Adjust enum usage with SystemTest Instances
794c02f
@rtjd6554
Adjust for IngestBatcherStore usage of OptionalStack
b50654b
@rtjd6554
Adjust usages for DockerImageConfiguration
0695e12
@patchwork01
Fix compilation in CleanUpDeletedSleeperInstancesTest
8667f0c
@patchwork01
Pass OptionalStack to DockerImageConfiguration from AdminClientProper…
fdc39a2 
…tiesStore
@patchwork01
Change type of field StacksForDockerUpload.stacks
298d74a
@patchwork01
Pass OptionalStack into StacksForDockerUpload
c9b6e64
@patchwork01
Only use enum in DockerImageConfiguration
eac888a
@patchwork01
Use OptionalStack in DeployDockerInstance
26f9dfd
@patchwork01
Update test usages of OptionalStack
0230a8e
@patchwork01
Refactor SystemTestOptionalStacks
d9b6181
@patchwork01
Use OptionalStack to enable/disable in system tests
3ffdc43
@patchwork01
Test case insensitivity in OptionalStackTest
adec1ff
@patchwork01 patchwork01 marked this pull request as ready for review September 17, 2024 13:35
Base automatically changed from 3195-default-reservedmax-concurrency-for-lambdas-scaling-across-sleeper-tables to develop September 17, 2024 13:38
@patchwork01 patchwork01 assigned gaffer01 and unassigned patchwork01 and gaffer01 Sep 17, 2024
@gaffer01 gaffer01 removed their assignment Sep 17, 2024
@patchwork01 patchwork01 merged commit ae2c87d into develop Sep 18, 2024
16 checks passed
@patchwork01 patchwork01 deleted the 3204-validate-optional-stacks branch September 18, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patchwork01 patchwork01 patchwork01 approved these changes

@gaffer01 gaffer01 gaffer01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate optional stacks
3 participants
@rtjd6554 @gaffer01 @patchwork01