Issue 1960 - Add properties for table batching lambdas memory & timeout #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patchwork01
reviewed
Mar 12, 2024
| @@ -216,6 +216,18 @@ public interface CommonProperty { | |||
| .validationPredicate(Utils::isTrueOrFalse) | |||
| .propertyGroup(InstancePropertyGroup.COMMON) | |||
| .build(); | |||
| UserDefinedInstanceProperty TABLE_BATCHING_LAMBDAS_MEMORY_IN_MB = Index.propertyBuilder("sleeper.table.batching.lambdas.memory") | |||
| .description("The amount of memory for lambdas that create table batches.") | |||
There was a problem hiding this comment.
Maybe "that create batches of tables to run some operation against, eg. create compaction jobs, garbage collection, partition splitting"?
There was a problem hiding this comment.
Thanks that sounds better, i've updated the description
patchwork01
approved these changes
Mar 12, 2024
patchwork01
deleted the
1960-property-for-table-batching-lambda-memory-and-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
PR"
Tests
Documentation
separate issue for that below.
NOTICES file to reflect this.