Permit building python bindings separately from libsdformat library (backport #1491) #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…1491) This allows the src/python_pybind11/CMakeLists.txt file to be built as a top-level cmake project against an external sdformat library, with documentation added to the README. The logic for finding pybind11 is also moved from the root CMakeLists.txt to python/CMakeLists.txt to reduce code duplication. When invoked through the root CMakeLists.txt, pybind11 is treated as an optional dependency, but when invoked from the python folder, pybind11 is treated as required by setting the variable CMAKE_REQUIRE_FIND_PACKAGE_pybind11 to TRUE. Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Silvio Traversaro <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]> (cherry picked from commit 3dcdd55) # Conflicts: # python/CMakeLists.txt
|
Cherry-pick of 3dcdd55 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
9 tasks
Signed-off-by: Steve Peters <[email protected]>
azeey
reviewed
Nov 6, 2024
| set(PYTHON_LIBRARIES "${PYTHON_DEBUG_LIBRARIES}") | ||
| # Detect if we are doing a standalone build of the bindings, using an external sdformat | ||
| if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) | ||
| cmake_minimum_required(VERSION 3.22.1) |
There was a problem hiding this comment.
Can you document this CMake version requirement?
There was a problem hiding this comment.
thanks for catching these!
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
azeey
approved these changes
Nov 6, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of osrf/homebrew-simulation#2834, related to gazebosim/gz-math#636
Summary
This allows the
python/CMakeLists.txtfile to be built as a top-level cmake project against an external libsdformat library. The first commit (1985c90) is a patch from @traversaro used in conda, and the second commit (4644d3b) replaces theGZ_LIB_INSTALL_DIRcmake variable withCMAKE_INSTALL_LIBDIR(see GzPackaging.cmake:111) sinceGZ_LIB_INSTALL_DIRis not defined with the minimal cmake project added in 1985c90.Test it
CMakeLists.txtwith using-DSKIP_PYBIND11=ONto build and install the libsdformat library without python bindings.python/CMakeLists.txtwith-DPython_EXECUTABLE=/path/to/pythonto build and install python bindings for a given python versionI have a draft of an updated homebrew formula using this branch in osrf/homebrew-simulation#2836
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.This is an automatic backport of pull request #1491 done by [Mergify](https://mergify.com).