Conform to ros format for header field frame_id of sensor msgs (#195) #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osim#195) Signed-off-by: ahcorde <[email protected]>
Merged
|
Thanks again! After #202 we'll open a 5 ➡️ 6 PR as explained in #201 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
Summary
There was a pull request solving an issue in the branch ign-sensors3: #195
However, I am using ignition-edifice and it uses ign-sensors6, but the issue is the very same as described in this pull request #195.
So I rebased this commit from branch ign-sensors3 to ign-sensors6. There was, fortunately, no merge conflict. Then, I built and used this library and it works now as expected.