Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "Conform to ros format for header field frame_id of sensor msgs #195" to all ignition versions #201

Open
halodluc opened this issue Mar 3, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@halodluc
Copy link

halodluc commented Mar 3, 2022

See #195 for the description. This pull request was merged in branch ign-sensors3, but I think it should be merged probably to all ignition versions.
I can confirm that it is necessary for ign-sensors6 and I created a new pull request solving my issue #200
However, I am not sure where else it is necessary and how to do it properly. So this is the reason why I created this issue.

Environment

@halodluc halodluc added the bug Something isn't working label Mar 3, 2022
@ahcorde
Copy link
Contributor

ahcorde commented Mar 3, 2022

Hi @halodluc

In general we create forward port (like this one). I will create one this week to push these changes

@chapulina
Copy link
Contributor

Hi @halodluc , thank you for opening this issue and PR #200. As @ahcorde mentioned, we prefer to do forward-ports as described on the contribution guide. I've started with #202 .

@halodluc
Copy link
Author

halodluc commented Mar 4, 2022

Hi, thank you very much!

@ahcorde
Copy link
Contributor

ahcorde commented Mar 7, 2022

5 ➡️ 6 PR #203

@doisyg
Copy link
Contributor

doisyg commented Apr 4, 2022

Already reported there #195, maybe I should open a separate issue but it seems that it works for laserscan msgs but not for pointclouds. I believe the type ignition.msgs.PointCloudPacked is missing the frame field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants