-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garden test cleanup #587
Garden test cleanup #587
Conversation
61c38d3
to
677f722
Compare
This cleans up physics tests in a few ways: Consolidate TestUtilities.hh and test/Utils.hh Move test headers to test/include/test Move mock headers to test/include/mock Create an INTERFACE library for test/mock headers that sets common compiler definitions as well as common libraries to link against Remove all instances of hardcoded world names or resource names and instead use constants. Signed-off-by: Michael Carroll <[email protected]>
677f722
to
8ef0023
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-physics6 #587 +/- ##
===============================================
- Coverage 78.64% 78.47% -0.17%
===============================================
Files 141 139 -2
Lines 7713 7611 -102
===============================================
- Hits 6066 5973 -93
+ Misses 1647 1638 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up! Just some minor comments
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
737b1c9
to
6b607d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not finished reviewing this, but here's a batch of comments
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@scpeters I have removed anything that was duplicated (or closely duplicated). This required some small changes in the tpe tests to match the common world files. |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Split from #513 for easier review.
This cleans up physics tests in a few ways:
TestUtilities.hh
andtest/Utils.hh
test/include/test
test/include/mock