Fix ExpectData compiler warnings #335
Conversation
Addresses #332 Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
remove_deprecated_copies
branch
from
734fb51
to
ddf028b
Compare
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 75.65% 75.65%
=======================================
Files 128 128
Lines 5537 5538 +1
=======================================
+ Hits 4189 4190 +1
Misses 1348 1348
Continue to review full report at Codecov.
|
|
@osrf-jenkins retest this please |
There was a problem hiding this comment.
As I was reviewing this PR, I realized that the assumption that the base class' (CompositeData) copy ctor will be called only holds in certain scenarios. Here's a code sample that demonstrates when CompositeData copy ctor gets called: https://godbolt.org/z/6o6jWGvj8.
From that I see that having a default copy assignment operator would work as expected, but the way we have implemented ExpectData's copy constructor doesn't work properly if we tried to use it directly to copy ExpectData objects. It works fine when we use the derived class SpecifyData. I'll open a separate issue about this.
Use default assignment operator. Addresses gazebosim#332. Signed-off-by: Michael Carroll <[email protected]>
Use default assignment operator. Addresses gazebosim#332. Signed-off-by: Michael Carroll <[email protected]>
Use default assignment operator. Addresses #332. Signed-off-by: Michael Carroll <[email protected]>
Addresses #332
Signed-off-by: Michael Carroll [email protected]