Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up nested namespaces #603

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

mjcarroll
Copy link
Contributor

Massive diff is mostly whitespace as I'm condensing namespaces.

This is to be ported forward to main.

Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jul 1, 2024
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  /github/workspace/include/gz/math/Cone.hh:189:  At least two spaces is best between code and comments  [whitespace/comments] [2]
  /github/workspace/include/gz/math/Triangle3.hh:283:  At least two spaces is best between code and comments  [whitespace/comments] [2]

Signed-off-by: Michael Carroll <[email protected]>
@scpeters
Copy link
Member

scpeters commented Jul 1, 2024

diff without whitespace: https://github.com/gazebosim/gz-math/pull/603/files?w=1

@mjcarroll mjcarroll self-assigned this Jul 1, 2024
@mjcarroll mjcarroll merged commit 0ebc06e into gz-math7 Jul 2, 2024
12 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/clean_namespaces branch July 2, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants