Forward port #603 to main #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Jul 2, 2024
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/namespaces_main
branch
from
69eac51 to
0b960c5
Compare
Signed-off-by: Michael Carroll <[email protected]>
scpeters
reviewed
Jul 2, 2024
| constexpr auto GZ_DEPRECATED(7) IGN_SIX_SIZE_T = &GZ_SIX_SIZE_T; | ||
| constexpr auto GZ_DEPRECATED(7) IGN_SEVEN_SIZE_T = &GZ_SEVEN_SIZE_T; | ||
| constexpr auto GZ_DEPRECATED(7) IGN_EIGHT_SIZE_T = &GZ_EIGHT_SIZE_T; | ||
| constexpr auto GZ_DEPRECATED(7) IGN_NINE_SIZE_T = &GZ_NINE_SIZE_T; |
There was a problem hiding this comment.
these should not be forward-ported
scpeters
requested changes
Jul 2, 2024
| /// timeSys.ElapsedRunTime()).count() << " ms\n"; | ||
| /// watch.Stop(); | ||
| /// ``` | ||
| class GZ_MATH_VISIBLE Stopwatch | ||
| { | ||
| // Use a steady clock | ||
| // This alias is now deprecated; please use std::chrono::steady_clock | ||
| // directly instead. | ||
| using clock | ||
| [[deprecated("As of 8.0, use std::chrono::steady_clock directly.")]] | ||
| = std::chrono::steady_clock; |
There was a problem hiding this comment.
this deprecated using statement should not be in the Stopwatch class
| { | ||
| namespace math | ||
| // Use a steady clock | ||
| using clock = std::chrono::steady_clock; |
Merged
|
this has conflicts; I've opened #611 as an alternative |
|
Replaced by #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port #603