Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Migration Process: Consider All Seeds and Warn for Provider Mismatch #2079

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Enhance Migration Process: Consider All Seeds and Warn for Provider Mismatch #2079

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cebdd3
fix: consider all seeds for migration and add warning for provider mi…
petersutter Sep 12, 2024
30e6e85
remove unused var
petersutter Sep 17, 2024
3453c40
PR feedback I
petersutter Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions frontend/src/components/GSeedConfiguration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ SPDX-License-Identifier: Apache-2.0
:items="seedNames"
persistent-hint
/>
<div
v-if="providerMismatch"
class="my-2"
>
Note: Ensure network connectivity for etcd backups and Shoot control plane. Without it, migration may stall.
</div>
</v-card-text>
</template>
</g-action-button-dialog>
Expand All @@ -43,8 +49,8 @@ import { useShootItem } from '@/composables/useShootItem'
import { errorDetailsFromError } from '@/utils/error'

import {
find,
map,
filter,
} from '@/lodash'

export default {
Expand All @@ -63,8 +69,19 @@ export default {
const seedStore = useSeedStore()

const seedNames = computed(() => {
const seeds = filter(seedStore.seedList, ['data.type', shootCloudProviderKind.value])
return map(seeds, 'metadata.name')
return map(seedStore.seedList, 'metadata.name')
})

const providerMismatch = computed(() => {
const selectedSeed = find(seedStore.seedList, ['metadata.name', seedName.value])
const sourceSeed = find(seedStore.seedList, ['metadata.name', shootSeedName.value])
if (!selectedSeed || !sourceSeed) {
return false
}
const selectedProvider = selectedSeed.data.type
const sourceProvider = sourceSeed.data.type
const shootProvider = shootCloudProviderKind.value
return selectedProvider !== sourceProvider || selectedProvider !== shootProvider
})

const seedName = ref(shootSeedName.value)
Expand All @@ -75,6 +92,7 @@ export default {
shootSeedName,
seedName,
seedNames,
providerMismatch,
}
},
methods: {
Expand Down