Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Migration Process: Consider All Seeds and Warn for Provider Mismatch #2079

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Enhance Migration Process: Consider All Seeds and Warn for Provider Mismatch #2079

merged 3 commits into from
Sep 25, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
This PR updates the seed selection process to consider all available seeds during Shoot migration, rather than filtering by provider type. It also adds a warning to inform users about potential provider mismatches and related network connectivity issues that could affect the migration.

Which issue(s) this PR fixes:
Fixes #2032

Special notes for your reviewer:

Release note:

Consider all seeds for Shoot migration and add warning for provider mismatch

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 12, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
grolu
grolu approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2024
holgerkoser
holgerkoser approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit d7fa200 into master Sep 25, 2024
8 checks passed
@petersutter petersutter deleted the enh/seed-migration branch September 25, 2024 14:27
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 25, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 14, 2024
@grolu grolu mentioned this pull request Oct 14, 2024
Open
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display Seeds of all providers when using the Configure Seed option in the dashboard
6 participants
@petersutter @holgerkoser @grolu @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot