Skip to content

Remove redundant rustup install commands from github workflows after ci-base-image update #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Remove redundant rustup install commands from github workflows after ci-base-image update #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36e1b9c
# Goal
Oct 20, 2023
abb1757
Merge branch 'main' into 1727-ci-base-image-bug
mattheworris Oct 24, 2023
270c12b
Merge branch 'main' into 1727-ci-base-image-bug
mattheworris Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ jobs:
uses: actions/configure-pages@v3
- name: Build Docs
run: |
rustup target add wasm32-unknown-unknown
rustup target add wasm32-unknown-unknown --toolchain nightly-2023-07-13
RUSTDOCFLAGS="--enable-index-page -Zunstable-options" cargo +nightly-2023-07-13 doc --no-deps --workspace --features frequency
- name: Fix file permissions
shell: sh
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/verify-pr-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,7 @@ jobs:
- name: Check Out Repo
uses: actions/checkout@v4
- name: Check
# Remove these install commands when ci-base-image has nightly toolchain
run: |
rustup toolchain install nightly-2023-07-13
rustup target add x86_64-unknown-linux-gnu --toolchain nightly-2023-07-13
cargo +nightly-2023-07-13 fmt --check

lint-rust-code:
Expand All @@ -215,10 +212,7 @@ jobs:
- name: Check Out Repo
uses: actions/checkout@v4
- name: Lint
# Remove these install commands when ci-base-image has nightly toolchain
run: |
rustup toolchain install nightly-2023-07-13
rustup target add x86_64-unknown-linux-gnu --toolchain nightly-2023-07-13
SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo +nightly-2023-07-13 clippy \
--features runtime-benchmarks,frequency-lint-check \
-- \
Expand All @@ -234,9 +228,7 @@ jobs:
- name: Check Out Repo
uses: actions/checkout@v4
- name: Build Docs
# Remove these install commands when ci-base-image has nightly toolchain
run: |
rustup toolchain install nightly-2023-07-13
rustup target add wasm32-unknown-unknown --toolchain nightly-2023-07-13
RUSTDOCFLAGS="--enable-index-page --check -Zunstable-options" cargo +nightly-2023-07-13 doc --no-deps --features frequency

Expand Down