Remove redundant rustup install commands from github workflows after ci-base-image update #1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1728 +/- ##
=======================================
Coverage 87.95% 87.95%
=======================================
Files 50 50
Lines 4243 4243
=======================================
Hits 3732 3732
Misses 511 511 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mattheworris
force-pushed
the
1727-ci-base-image-bug
branch
from
157435e to
4c9c940
Compare
github-actions
bot
added
metadata-changed
mattheworris
changed the title
github-actions
bot
added
metadata-changed
This PR aims to remove the `rustup install toolchain nightly` commands from the individual GitHub jobs that use the `ci-base-image` that previously did not have the `nightly` toolchain. Closes #1727 # Discussion The changes in the previous PR (#1700) to add the `nightly` toolchain to `ci-base-image` were not published to DockerHub until the `merge-pr.yml` workflow actions were successfully run. Therefore the `nightly` toolchain was not available for CI to use in `ci-base-image`. In that PR, the `nightly` toolchain was installed in the individual jobs where it was needed to pass CI. Now that the PR has been merged, `ci-base-image` has been updated with both the `stable` and `nightly` toolchains and the redundant `rustup install` commands can be removed from `verify-pr-commit.yml`.
mattheworris
force-pushed
the
1727-ci-base-image-bug
branch
from
0f83749 to
36e1b9c
Compare
wilwade
approved these changes
Oct 25, 2023
JoeCap08055
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR aims to remove the
rustup install toolchain nightlycommands from the individual GitHub jobs that use theci-base-imagethat previously did not have thenightlytoolchain.Closes #1727
Discussion
The changes in the previous PR (#1700) to add the
nightlytoolchain toci-base-imagewere not published to DockerHub until themerge-pr.ymlworkflow actions were successfully run. Therefore thenightlytoolchain was not available for CI to use inci-base-image.In that PR, the
nightlytoolchain was installed in the individual jobs where it was needed to pass CI.Now that the PR has been merged,
ci-base-imagehas been updated with both thestableandnightlytoolchains and the redundantrustup installcommands can be removed fromverify-pr-commit.yml.