e6000sw: Add support for MV88E6190X switch variant #1408
+28
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salekseev
force-pushed
the
e6000sw_support_6190x
branch
from
c82471c
to
4e7ba71
Compare
rilysh
reviewed
Sep 4, 2024
salekseev
force-pushed
the
e6000sw_support_6190x
branch
6 times, most recently
from
5e19f53
to
7ea66cb
Compare
rilysh
reviewed
Sep 5, 2024
salekseev
force-pushed
the
e6000sw_support_6190x
branch
from
7ea66cb
to
8aece39
Compare
salekseev
force-pushed
the
e6000sw_support_6190x
branch
2 times, most recently
from
d359a43
to
812efad
Compare
rilysh
reviewed
Sep 6, 2024
salekseev
force-pushed
the
e6000sw_support_6190x
branch
2 times, most recently
from
0ef3d9c
to
475d528
Compare
This commit adds support for MV88E6190X switch variant that is similar to MV88E6190 in its configuration. It also adds is6190x hint support for enabling on amd64 platform without device tree support. PR: 281211 Signed-off-by: Stas Alekseev <[email protected]>
salekseev
force-pushed
the
e6000sw_support_6190x
branch
from
8a68b7c
to
ae6652e
Compare
salekseev
commented
Sep 13, 2024
Comment on lines
+263
to
+265
| if (resource_int_value(device_get_name(sc->dev), | ||
| device_get_unit(sc->dev), "is6190x", &is_6190x) != 0) | ||
| return; |
There was a problem hiding this comment.
This should avoid the following error: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
rilysh
reviewed
Sep 18, 2024
| @@ -260,8 +260,9 @@ e6000sw_probe(device_t dev) | |||
| */ | |||
| resource_int_value(device_get_name(sc->dev), | |||
| device_get_unit(sc->dev), "is8190", &is_6190); | |||
| resource_int_value(device_get_name(sc->dev), | |||
| device_get_unit(sc->dev), "is6190x", &is_6190x); | |||
| if (resource_int_value(device_get_name(sc->dev), | |||
There was a problem hiding this comment.
If "is6190" is available, but "is6190x" isn't, it will just stop the execution (according to resource_int_value() function, source: https://github.com/freebsd/freebsd-src/blob/abed32f91d01d91faa709622e3279e9baec37272/sys/kern/subr_hints.c#L338). I'm not exactly sure if MV88E6190 and MV88E6190X are related to each other (without one either one can't work).
Also, return isn't returning any meaningful values, and the function expects an integer.
|
rylish's comments need to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for MV88E6190X switch variant that is similar to MV88E6190 in its configuration.
It also adds is6190x hint support for enabling on amd64 platform without device tree support.
PR: 281211