Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

68 the validateatom of listatom should listen to the validation of inner fields #69

Merged
merged 3 commits into from
Jan 11, 2024

fix(listAtom): combined errors from nested forms & field itself

9e181f3
Select commit
Loading
Failed to load commit list.
Merged

68 the validateatom of listatom should listen to the validation of inner fields #69

fix(listAtom): combined errors from nested forms & field itself
9e181f3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 11, 2024 in 1s

89.80% (-1.31%) compared to d36ed47

View this Pull Request on Codecov

89.80% (-1.31%) compared to d36ed47

Details

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (d36ed47) 91.10% compared to head (9e181f3) 89.80%.
Report is 7 commits behind head on next.

Files Patch % Lines
src/components/form/FormSubmitValues.ts 0.00% 50 Missing and 1 partial ⚠️
src/atoms/list-atom/listAtom.ts 98.36% 6 Missing ⚠️
src/atoms/schemaValidate.ts 98.59% 1 Missing ⚠️
src/components/form/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             next      #69      +/-   ##
==========================================
- Coverage   91.10%   89.80%   -1.31%     
==========================================
  Files          86       86              
  Lines        2092     2158      +66     
  Branches      166      177      +11     
==========================================
+ Hits         1906     1938      +32     
- Misses        186      218      +32     
- Partials        0        2       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov