Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

68 the validateatom of listatom should listen to the validation of inner fields #69

Conversation

MiroslavPetrik
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (d36ed47) 91.10% compared to head (9e181f3) 89.80%.
Report is 7 commits behind head on next.

Files Patch % Lines
src/components/form/FormSubmitValues.ts 0.00% 50 Missing and 1 partial ⚠️
src/atoms/list-atom/listAtom.ts 98.36% 6 Missing ⚠️
src/atoms/schemaValidate.ts 98.59% 1 Missing ⚠️
src/components/form/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #69      +/-   ##
==========================================
- Coverage   91.10%   89.80%   -1.31%     
==========================================
  Files          86       86              
  Lines        2092     2158      +66     
  Branches      166      177      +11     
==========================================
+ Hits         1906     1938      +32     
- Misses        186      218      +32     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MiroslavPetrik MiroslavPetrik merged commit 48ec650 into next Jan 11, 2024
2 of 3 checks passed
MiroslavPetrik added a commit that referenced this pull request Jan 11, 2024
#70)

* 68 the validateatom of listatom should listen to the validation of inner fields (#69)

* chore(vite): update & cleanup (#67)

* test(listAtom): failing test for itemError

* fix(listAtom): combined errors from nested forms & field itself

* 68 the validateatom of listatom should listen to the validation of inner fields (#71)

* test(listAtom): failing test for itemError

* fix(listAtom): combined errors from nested forms & field itself

* fix: form reset clear error
MiroslavPetrik added a commit that referenced this pull request Jan 11, 2024
…validation of in… (#70)

* 68 the validateatom of listatom should listen to the validation of inner fields (#69)

* chore(vite): update & cleanup (#67)

* test(listAtom): failing test for itemError

* fix(listAtom): combined errors from nested forms & field itself

* 68 the validateatom of listatom should listen to the validation of inner fields (#71)

* test(listAtom): failing test for itemError

* fix(listAtom): combined errors from nested forms & field itself

* fix: form reset clear error
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
## [4.0.1](v4.0.0...v4.0.1) (2024-01-11)

### Bug Fixes

* **listAtom:** [#68](#68) the validateatom of listatom should listen to the validation of in… ([#70](#70)) ([1679827](1679827)), closes [#69](#69) [#67](#67) [#71](#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant