move all files related to the OpenType profile to a dedicated subdirectory #4391
Conversation
|
@simoncozens please take a look. I am doing this before splitting the Google Fonts profile into smaller files. I decided to move the files to dedicated per-profile subdirectory to keep the code easier to navigate. Otherwise, unrelated files would be placed side-by-side on the profiles dir. |
felipesanches
force-pushed
the
refactoring_profiles
branch
2 times, most recently
from
f8b989e to
bdba010
Compare
|
OK. I see that there are some linter issues that I still have to address. I'll let you know when this is actually ready for review. |
| profile_imports = ( | ||
| ( | ||
| ".", |
There was a problem hiding this comment.
I don't quite understand how profile_imports works (why do we even have our own system for importing things?!) but can't we change just this to .opentype and leave the rest?
* imports are a bad idea (as the linter is telling you) because they make the namespace unpredictable. It's fine for something like this where we're not really doing any code, but in general you don't want adding a utility function to module B to suddenly add a new defined symbol to module A.
There was a problem hiding this comment.
It is part of the "magic" behaviour of inferring conditions and args to checks.
I have been actually working on a refactor of the profile to not use those profile_import
statements, but by doing so, I think I started to grasp why they're there.
I'm pushing an updated set of commits now
There was a problem hiding this comment.
yes, I agree about the import * being usually a bad idea.
felipesanches
force-pushed
the
refactoring_profiles
branch
from
bdba010 to
b443e3b
Compare
felipesanches
force-pushed
the
refactoring_profiles
branch
from
b443e3b to
0686ac7
Compare
|
(to be addressed only after PR #4491) |
No description provided.