Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fonttools/fontbakery
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bdba010bb85135d9854882d30ab92dbd3d8af908
Choose a base ref
..
head repository: fonttools/fontbakery
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b443e3bc2aeca9972e682ddf3b36938889d6f80b
Choose a head ref
Showing with 23 additions and 22 deletions.
  1. +16 −16 Lib/fontbakery/profiles/opentype/__init__.py
  2. +1 −3 Lib/fontbakery/profiles/opentype/name.py
  3. +6 −3 Lib/fontbakery/profiles/opentype/os2.py
32 changes: 16 additions & 16 deletions Lib/fontbakery/profiles/opentype/__init__.py
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
from fontbakery.fonts_profile import profile_factory
from fontbakery.section import Section

from .cff import *
from .cmap import *
from .head import *
from .os2 import *
from .post import *
from .name import *
from .loca import *
from .hhea import *
from .dsig import *
from .gdef import *
from .gpos import *
from .kern import *
from .glyf import *
from .fvar import *
from .stat import *
from .layout import *
from .cff import * # noqa:F401,F403
from .cmap import * # noqa:F401,F403
from .head import * # noqa:F401,F403
from .os2 import * # noqa:F401,F403
from .post import * # noqa:F401,F403
from .name import * # noqa:F401,F403
from .loca import * # noqa:F401,F403
from .hhea import * # noqa:F401,F403
from .dsig import * # noqa:F401,F403
from .gdef import * # noqa:F401,F403
from .gpos import * # noqa:F401,F403
from .kern import * # noqa:F401,F403
from .glyf import * # noqa:F401,F403
from .fvar import * # noqa:F401,F403
from .stat import * # noqa:F401,F403
from .layout import * # noqa:F401,F403

profile_imports = (
(
4 changes: 1 addition & 3 deletions Lib/fontbakery/profiles/opentype/name.py
Original file line number Diff line number Diff line change
@@ -7,8 +7,6 @@
WindowsEncodingID,
WindowsLanguageID,
)
from fontbakery.utils import markdown_table
from fontbakery.profiles.shared_conditions import glyph_metrics_stats, is_ttf, is_cff


@check(
@@ -422,7 +420,7 @@ def com_google_fonts_check_name_match_familyname_fullfont(ttFont):
def com_adobe_fonts_check_postscript_name(ttFont):
"""PostScript name follows OpenType specification requirements?"""
import re
from fontbakery.utils import get_name_entry_strings
from fontbakery.utils import get_name_entry_strings, markdown_table

bad_entries = []

9 changes: 6 additions & 3 deletions Lib/fontbakery/profiles/opentype/os2.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from fontbakery.callable import check
from fontbakery.status import FAIL, PASS, WARN, INFO, SKIP
from fontbakery.message import Message
from fontbakery.profiles.shared_conditions import vmetrics
from fontbakery.profiles.googlefonts_conditions import RIBBI_ttFonts
from fontbakery.profiles.googlefonts_conditions import ( # noqa:F401,E501 pylint:disable=W0611
RIBBI_ttFonts,
)


@check(
@@ -246,7 +247,9 @@ def com_adobe_fonts_check_fsselection_matches_macstyle(ttFont):
""",
proposal="https://github.com/fonttools/fontbakery/pull/2388",
)
def com_adobe_fonts_check_family_bold_italic_unique_for_nameid1(RIBBI_ttFonts):
def com_adobe_fonts_check_family_bold_italic_unique_for_nameid1(
RIBBI_ttFonts, # noqa:F811
):
"""Check that OS/2.fsSelection bold & italic settings are unique
for each NameID1"""
from collections import Counter