Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navdata): allow airports to be used as fixes #9792

Merged
merged 7 commits into from
Jan 25, 2025

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Jan 20, 2025

Fixes #[issue_no]

Summary of Changes

  • Allows airports to be used as fixes in instrument procedures. This seems to be more common in the LIDO data MSFS uses now.
  • Fixed an issue where airports referenced as fixes could not be loaded in MSFS2020 (airports do not have region codes in 2020, but they do when referenced as fixes in procedure legs).

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

The proc I tested this with won't load for a different reason at the moment... so don't have a good way to test.
Use MSFS default navdata. Try EWR5 SID out of Newark, make sure it's selectable and loads.
Test and make sure some instrument procedures you normally use load okay, and look good on the ND in plan mode.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added this to the v0.13.0 milestone Jan 20, 2025
@tracernz tracernz requested a review from Benjozork January 20, 2025 08:33
@tracernz

This comment was marked as off-topic.

@BravoMike99
Copy link
Contributor

Dev Team QA Report

Discord Username : bruno_pt99
Object of testing : #9792
Aircraft : A32NX
Tier of Testing : 1
Date : 25/01/2025

Testing Process:
Tested in 2020:
Loaded EWR5 SID, checked it is selectable and loads ✔️
Loaded a few procedures such as LPPT LAZET1A, IXIDA1N & LPPR ABLEG6C and verified they load & are displayed correctly ✔️

Testing Results:
Passed

Media:
EWR5
LPPR
IXIDA1N
LAZET1A

@tracernz tracernz enabled auto-merge (squash) January 25, 2025 10:41
@tracernz tracernz merged commit b080929 into flybywiresim:master Jan 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants