Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/mfd): basic FIX INFO functionality and lat rev menu fixes #9471

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

Benjozork
Copy link
Member

@Benjozork Benjozork commented Nov 10, 2024

Summary of Changes

  • Basic FIX INFO functionality
    • NOT IN DATABASE
    • Placeholders for predictions text
    • Misisng details (ABEAM button, etc.)
    • Make sure alll true/mag stuff is correct
  • Fixes some instances of lateral revisions being available on flight plan elements where they should not be

Testing instructions

  • Insert FIX INFOs for different points
    • Waypoints
    • VORs/NDBs
    • Airports
    • Runways (format: KSFO28R)
  • Make sure FIX INFO data remains stable when switching away/to the page, switching tabs, between both MFDs, etc.
  • Make sure testing instructions from fix(fm): use station declination for radials #8182 still pass
  • Make sure A320 FIX INFO functionality is still working correctly

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@Benjozork Benjozork changed the title feat: initial commit feat(a380x/mfd): basic FIX INFO functionality Nov 10, 2024
@alepouna alepouna added A380X Related to the A380X aircraft ND (Navigation Display) FMS labels Nov 10, 2024
@Benjozork Benjozork removed the ND (Navigation Display) label Nov 10, 2024
@Benjozork Benjozork changed the title feat(a380x/mfd): basic FIX INFO functionality feat(a380x/mfd): basic FIX INFO functionality and lat rev menu fixes Nov 11, 2024
@FDM-Tech

This comment was marked as off-topic.

@Benjozork
Copy link
Member Author

It'll be merged when it's ready.

@2hwk 2hwk added the Not Ready For Review Still draft but needs a GitHub build label Nov 15, 2024
@2hwk 2hwk added this to the v0.13.0 milestone Nov 15, 2024
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/MFD/MfdPageDirectory.tsx
#	fbw-a380x/src/systems/instruments/src/MFD/pages/common/Button.tsx
@Benjozork Benjozork marked this pull request as ready for review November 30, 2024 04:30
@Benjozork Benjozork requested review from flogross89 and removed request for flogross89 November 30, 2024 18:07
@Benjozork Benjozork removed the Not Ready For Review Still draft but needs a GitHub build label Dec 12, 2024
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions, thanks

@Ueeew
Copy link

Ueeew commented Jan 4, 2025

@Benjozork I just saw your PR and I want to test it but I noticed thats a bit out of date now, so I have just a small request: could you just merge the "master" file again into your pull-request so thats up-to-date again. That would be great. Thanks

@tracernz tracernz dismissed their stale review January 5, 2025 01:45

Changes made.

@Ueeew
Copy link

Ueeew commented Jan 5, 2025

@Benjozork If tested, and firstly, I want to say thank you for your work. It works good, and it is really nice to have a fix-info page now. There are just a few small bugs I found. The first thing I found is that I was not able to delete fixes I entered previously in the flight. The second bug is that the Fix 4 doesn't work; the things you enter there are not getting displayed. But beside these bugs, it's really good. And at the end, I have a small request. I don't know if this has to do with the fix info, but could you add the option to enter your own waypoints and airports? Thank you for all your work. :)

@Rocket-Nerd
Copy link

External QA Report

Discord Username : rocketnerd
Object of testing : #9471
Aircraft : A380X
Tier of Testing : 1/2
Date : 4/1/2025

Testing Process:

  1. Started up AC from cold and dark
  2. Loaded the KSFO quiet bridge visual using PDBs as shown in the testing instructions
  3. Used fix info to display the 095 radial from the SFO VOR, made sure it aligned with the PBDs for the approach
  4. Created fix info for the ARCHI waypoint, made sure it aligned with the path to first PBD on the approach as per the charts
  5. Created fix info for the KSFO28R
  6. Checked to make sure fixed synced across FMS 1 and 2

Testing Results:
Passed

Negatives:

  1. Fix info does not load until the return button is pressed
  2. Cannot remove a radial from a given fix, only can be done by renaming the fix which resets all radials/radius

Media:
image46
image45

# Conflicts:
#	.github/CHANGELOG.md
#	fbw-a380x/src/systems/instruments/src/MFD/FMC/FlightManagementComputer.ts
#	fbw-a380x/src/systems/instruments/src/MFD/FMC/FmcService.ts
#	fbw-a380x/src/systems/instruments/src/MFD/pages/README.md
#	fbw-a380x/src/systems/instruments/src/MFD/pages/common/Button.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft FMS QA Failed
Projects
Status: 🔴 Code Review: In progress
Development

Successfully merging this pull request may close these issues.

8 participants