-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a32nx): accurate altimetry and split baro corrections #9659
Open
tracernz
wants to merge
27
commits into
flybywiresim:master
Choose a base branch
from
tracernz:mrc-altimetry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will later be moved into the DMC simulation in VCockpitLogic that we will also use for display switching.
tracernz
added
QA Tier 2
A32NX
Related to the A32NX aircraft
A380X
Related to the A380X aircraft
labels
Dec 14, 2024
This is in no way specific to altimeter 4 (or 3 before).
Saschl
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks very good to me, did not perform a very in depth review as it's quite extensive. But overall LGTM. Fix the rust tests and we can get this tested :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6717
Fixes #8397
Fixes #9649
Fixes #9507
Summary of Changes
The MSFS altimeters are now allocated as follows (for the benefit of third parties, the ISIS (for now...), and a few systems that need fixed):
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Perform full flights and look out for any altitude errors. Cross-check with the ISIS.
Perform failure scenarios of FCUs, ADRs. #9658 should merge first before these tests.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.