-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/pfd): Add FCU ALT ABOVE/BELOW A/C FMA messages #9674
base: master
Are you sure you want to change the base?
feat(a380x/pfd): Add FCU ALT ABOVE/BELOW A/C FMA messages #9674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look over some parts, but in general that's exactly how you can and should use MappedSubjects :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thank you! And sorry for the late re-review, slipped through. Feel free to ping me on Discord or here if a reply takes more than one week.
Thanks for the review! No problem, I just figured you had a lot of work and didn't want to "annoy" you :D Okay, I'll do next time, thanks! |
Please resolve conflicts when able |
I'm trying to, it's just that I'm having some issues, that's why there are so many commits right now, sorry for that. |
No worries, I guess it must have been the disconnect ap for landing pr which got merged since then. Don't hesitate to ask for help on the discord if you need (ignore the close, miss click on mobile 😅 ) |
You're right, the issues were because of that code 😅 Thanks, I managed to fix it (I hope it'll work out on the first try next time), so conflicts resolved 👍 |
Fixes #9410
Summary of Changes
Adds the "FCU ALT ABOVE A/C" and "FCU ALT BELOW A/C" FMA messages
Screenshots (if necessary)
References
Issue linked
Additional context
Discord username (if different from GitHub): Pruznak
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.