Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/pfd): Add FCU ALT ABOVE/BELOW A/C FMA messages #9674

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Pruznak
Copy link

@Pruznak Pruznak commented Dec 22, 2024

Fixes #9410

Summary of Changes

Adds the "FCU ALT ABOVE A/C" and "FCU ALT BELOW A/C" FMA messages

Screenshots (if necessary)

Screenshot 2024-12-22 112216
Screenshot 2024-12-22 112341

References

Screenshot 2024-12-22 111442

Issue linked

Additional context

Discord username (if different from GitHub): Pruznak

Testing instructions

  1. Load up aircraft, take off, climb to any altitude
  2. Select the HDG / VS mode on the FCU
  3. Select any positive VS, any altitude below current one and engage VS - make sure "FCU ALT BELOW A/C" is displayed on the FMA and does not disappear until you either: 1) Set VS to 0 or 2) Set VS to any negative value or 3) Disengage VS (switch to any other vertical mode)
  4. Select any negative VS, any altitude above current one and engage VS - make sure "FCU ALT ABOVE A/C" is displayed on the FMA and disappears only after: 1) roughly 10 seconds have passed since it displayed or 2) You set VS to 0 or 3) You set VS to any positive value or 4) You disengage VS (switch to any other vertical mode)
  5. Switch to TRK / FPA mode on the FCU and repeat steps 3 and 4 with FPA
  6. Make sure when switching HDG / VS and TRK / FPA modes while either message is displayed doesn't result in it disappearing

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look over some parts, but in general that's exactly how you can and should use MappedSubjects :)

fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx Outdated Show resolved Hide resolved
fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx Outdated Show resolved Hide resolved
fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx Outdated Show resolved Hide resolved
fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx Outdated Show resolved Hide resolved
fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx Outdated Show resolved Hide resolved
@Pruznak Pruznak requested a review from flogross89 December 22, 2024 20:24
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thank you! And sorry for the late re-review, slipped through. Feel free to ping me on Discord or here if a reply takes more than one week.

@flogross89 flogross89 added FMA QA A380 Only QA only for A380 required A380X Related to the A380X aircraft QA Ready to Test labels Jan 8, 2025
@Pruznak
Copy link
Author

Pruznak commented Jan 9, 2025

Looks good to me now, thank you! And sorry for the late re-review, slipped through. Feel free to ping me on Discord or here if a reply takes more than one week.

Thanks for the review! No problem, I just figured you had a lot of work and didn't want to "annoy" you :D Okay, I'll do next time, thanks!

@BravoMike99
Copy link
Contributor

Please resolve conflicts when able

@Pruznak
Copy link
Author

Pruznak commented Jan 9, 2025

Please resolve conflicts when able

I'm trying to, it's just that I'm having some issues, that's why there are so many commits right now, sorry for that.

@BravoMike99
Copy link
Contributor

BravoMike99 commented Jan 9, 2025

Please resolve conflicts when able

I'm trying to, it's just that I'm having some issues, that's why there are so many commits right now, sorry for that.

No worries, I guess it must have been the disconnect ap for landing pr which got merged since then. Don't hesitate to ask for help on the discord if you need (ignore the close, miss click on mobile 😅 )

@BravoMike99 BravoMike99 closed this Jan 9, 2025
@BravoMike99 BravoMike99 reopened this Jan 9, 2025
@Pruznak
Copy link
Author

Pruznak commented Jan 9, 2025

Please resolve conflicts when able

I'm trying to, it's just that I'm having some issues, that's why there are so many commits right now, sorry for that.

No worries, I guess it must have been the disconnect ap for landing pr which got merged since then. Don't hesitate to ask for help on the discord if you need (ignore the close, miss click on mobile 😅 )

You're right, the issues were because of that code 😅 Thanks, I managed to fix it (I hope it'll work out on the first try next time), so conflicts resolved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft FMA QA A380 Only QA only for A380 required QA Ready to Test
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

[A380X] FCU ALT ABOVE/BELOW A/C on FMA (Batch 7)
4 participants