Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380): Fix T/D prediction in PERF CRZ & add T/D reached #9284

Merged
merged 17 commits into from
Nov 13, 2024

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Nov 1, 2024

Fixes #8990

Summary of Changes

Changes time prediction in PERF page to show the ETA instead of remaining flight time if flight phase is not preflight.
Adds T/D prediction to PERF Cruise page.
Adds T/D Reached message to both PFD and MFD.
PFD code cleanup (remove non applicable messages) & some scratch pad messages were reworded to match a380.

Screenshots (if necessary)

Pred
TD REACHED

References

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

  1. Initialize all data in the FMS
  2. Observe the ETA in the PERF CRZ or PERF DES pages before takeoff. It should indicate the total flight time.
  3. After takeoff observe the same prediction as 2). It should now indicate the ETA at the destination.
  4. Once in cruise flight, verify that the T/D distance and time predictions are available on the MFD on the PERF CRZ Page.
  5. While flying in managed speed, don't initiate a descend after passing the T/D. "T/D REACHED" message should appear on both PFD & MFD.
  6. Clear the scratchpad message which should make it disappear from both displays.
    6.1) Do the same as 5) but initiate a descent instead of manually clearing the message. Once that happens, the message should disappear from both displays.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@2hwk 2hwk added this to the v0.13.0 milestone Nov 2, 2024
@2hwk 2hwk added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft QA Ready to Test QA Tier 1 labels Nov 2, 2024
@2hwk 2hwk removed the QA A380 Only QA only for A380 required label Nov 13, 2024
@2hwk
Copy link
Member

2hwk commented Nov 13, 2024

Quality Assurance Tester Report

Discord Username: 2cas
Object of testing: #9284
Aircraft: A380X
Tier of Testing: 1
Date: 13/11/2024

Testing Process:

  • Initialize all data in the FMS
  • Observe the ETA in the PERF CRZ or PERF DES pages before takeoff. It should indicate the total flight time.
  • After takeoff observe the same prediction as 2). It should now indicate the ETA at the destination.
  • Once in cruise flight, verify that the T/D distance and time predictions are available on the MFD on the PERF CRZ Page.
  • While flying in managed speed, don't initiate a descend after passing the T/D. "T/D REACHED" message should appear on both PFD & MFD.
  • Clear the scratchpad message which should make it disappear from both displays.
  • 6.1) Do the same as 5) but initiate a descent instead of manually clearing the message. Once that happens, the message should disappear from both displays.

Testing Results:

  • QA Passed

Negatives:

  • N/A

Conclusions:

  • LGTM

@2hwk 2hwk enabled auto-merge (squash) November 13, 2024 15:38
@2hwk 2hwk merged commit 0a7db45 into flybywiresim:master Nov 13, 2024
8 checks passed
@BravoMike99 BravoMike99 deleted the fix-380-mfd-pfd-td branch November 13, 2024 18:50
@heclak heclak mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

a380x/mfd: Perf page ETA format incorrect
2 participants