-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380): Fix T/D prediction in PERF CRZ & add T/D reached #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hwk
approved these changes
Nov 2, 2024
2hwk
added
QA A380 Only
QA only for A380 required
A380X
Related to the A380X aircraft
QA Ready to Test
QA Tier 1
labels
Nov 2, 2024
2hwk
reviewed
Nov 2, 2024
fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/MfdFmsPerf.tsx
Outdated
Show resolved
Hide resolved
BravoMike99
force-pushed
the
fix-380-mfd-pfd-td
branch
from
November 2, 2024 10:04
bd3bce9
to
37cd79a
Compare
Quality Assurance Tester Report Discord Username: 2cas Testing Process:
Testing Results:
Negatives:
Conclusions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8990
Summary of Changes
Changes time prediction in PERF page to show the ETA instead of remaining flight time if flight phase is not preflight.
Adds T/D prediction to PERF Cruise page.
Adds T/D Reached message to both PFD and MFD.
PFD code cleanup (remove non applicable messages) & some scratch pad messages were reworded to match a380.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
6.1) Do the same as 5) but initiate a descent instead of manually clearing the message. Once that happens, the message should disappear from both displays.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.