Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a32nx): accurate altimetry and split baro corrections #9659

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Dec 14, 2024

Fixes #6717
Fixes #8397
Fixes #9649
Fixes #9507

Summary of Changes

  • Implement accurate altimetry computations from static pressure.
  • Split EIS baro corrections between captain and first officer side.
  • Increased available baro correction range to 745-1100 hPa.
  • Add baro ref and altitude discrepancy FWC warnings.
  • Add CHECK ALT message on PFD.
  • Fixed the A380X to the extent necessary for everything to still work, and extended the baro range to 745-1100 hPa. We cannot split the baro corrections here due to the 3D model, but plenty of prep work is done.

The MSFS altimeters are now allocated as follows (for the benefit of third parties, the ISIS (for now...), and a few systems that need fixed):

  • 1: captain side
  • 2: first officer side
  • 3: ISIS (will need 2 of these eventually in A380X)...
  • 4: legacy/deprecated "autopilot" pressure altitude altimeter, to be deleted in the future.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Perform full flights and look out for any altitude errors. Cross-check with the ISIS.
Perform failure scenarios of FCUs, ADRs. #9658 should merge first before these tests.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added QA Tier 2 A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft labels Dec 14, 2024
@tracernz tracernz added this to the v0.13.0 milestone Dec 14, 2024
@tracernz tracernz marked this pull request as ready for review December 16, 2024 09:32
Copy link
Contributor

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks very good to me, did not perform a very in depth review as it's quite extensive. But overall LGTM. Fix the rust tests and we can get this tested :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft QA Tier 2
Projects
None yet
2 participants