Changes the build system to CMake #56

ilumsden · 2023-11-13T16:00:13Z

Since @hariharan-devarajan mentioned that we wanted to do this and since I had some free time on the flight to SC, I just went ahead and started implementing a CMake-based build system for DYAD.

As of now, this PR just implements a drop-in replacement for autotools. It does not restructure the code base, add any major changes to the code, etc.

In case anyone else wants to contribute to this, I put the branch directly on this repo (as opposed to a fork).

hariharan-devarajan · 2023-11-22T18:19:42Z

@ilumsden I will be looking into this actively. I will look at your branch and continue this work from here.

hariharan-devarajan · 2023-11-23T05:28:11Z

Did the following changes.

Enabled CMake based Build
Disabled Python test as its hanging.

CMakeLists.txt

CMake/dyad-config.cmake.build.in

CMake/dyad-config.cmake.install.in

hariharan-devarajan · 2023-12-01T08:13:44Z

@JaeseungYeom I fixed all the changes we talked about. Let me know if u think i should change anything else.

src/dyad/core/CMakeLists.txt

src/dyad/dtl/CMakeLists.txt

src/dyad/core/CMakeLists.txt

src/dyad/modules/CMakeLists.txt

1. Removed dyad_code from public headers 2. used PROJECT_NAME variable for all code 3. prefixed PROJECT_NAME for util code to avoid conflicts

JaeseungYeom · 2024-01-13T03:34:34Z

Usually when I forgot to specify CMAKE_INSTALL_PREFIX with cmake command, I still make it work by editing the variable in cmake_install.cmake that is generated under build directory. However, I see INSTALL DESTINATION is fixed rather than depending on CMAKE_INSTALL_PREFIX. Can this behavior changed?

JaeseungYeom · 2024-01-13T03:39:18Z

Also, can you confirm the python test is working?

…LL_PREFIX

hariharan-devarajan · 2024-01-16T23:45:39Z

Usually when I forgot to specify CMAKE_INSTALL_PREFIX with cmake command, I still make it work by editing the variable in cmake_install.cmake that is generated under build directory. However, I see INSTALL DESTINATION is fixed rather than depending on CMAKE_INSTALL_PREFIX. Can this behavior changed?

I fixed it can u check it?

…ctor � Conflicts: � .github/workflows/compile_test.yaml

hariharan-devarajan · 2024-01-16T23:50:39Z

Also, can you confirm the python test is working?

It is working locally but not on CI.

JaeseungYeom · 2024-01-17T06:45:36Z

Usually when I forgot to specify CMAKE_INSTALL_PREFIX with cmake command, I still make it work by editing the variable in cmake_install.cmake that is generated under build directory. However, I see INSTALL DESTINATION is fixed rather than depending on CMAKE_INSTALL_PREFIX. Can this behavior changed?

I fixed it can u check it?

Yes. It works.

JaeseungYeom · 2024-01-17T06:46:06Z

Should python binding be installed as well?

hariharan-devarajan · 2024-01-17T07:12:02Z

Should python binding be installed as well?

Generally it's done the other way around where we install cmake project from pip. I can show u an example with that and discuss the changes in a different pr

JaeseungYeom · 2024-01-17T09:15:44Z

CMakeLists.txt

+set_property(CACHE DYAD_CONTROL_PLANE PROPERTY STRINGS FLUX_RPC)
+set(DYAD_DATA_PLANE "FLUX_RPC" CACHE STRING "Protocol to use for DYAD's Data Plane")
+set_property(CACHE DYAD_DATA_PLANE PROPERTY STRINGS FLUX_RPC UCX)
+set(DYAD_PROFILER "NONE" CACHE STRING "Protocol to use for DYAD's Data Plane")


description of the option is irrelevant.

JaeseungYeom · 2024-01-17T09:16:15Z

CMakeLists.txt

+#------------------------------------------------------------------------------
+# Build Type based configurations
+#------------------------------------------------------------------------------
+set(CMAKE_C_FLAGS ${CMAKE_C_FLAGS} -std=c99)


We should just use the consistent standard with c++

when i switch the code to c++ we can move that right?

Initial work on converting DYAD from autotools to CMake

f697f49

ilumsden added the enhancement New feature or request label Nov 13, 2023

ilumsden self-assigned this Nov 13, 2023

ilumsden added 3 commits November 20, 2023 12:17

Updates compile_test.yaml to use CMake instead of Autotools

8adab39

Typo fix

51194ce

Removes "VERSION" from find_package since it's not actually correct

25504e5

hariharan-devarajan added 6 commits November 22, 2023 16:42

refactored and initial changes to build.

a563f9f

fixes for installation.

d166da2

fixed streaming apis.

ef5b3e8

fixed installation script.

b77a3b5

fixed CI

987ffd2

fixed CI

f8bb92e

hariharan-devarajan force-pushed the cmake_refactor branch 3 times, most recently from 43d1df3 to b9c6f46 Compare November 23, 2023 04:16

fix ucx compile

b9a5311

hariharan-devarajan force-pushed the cmake_refactor branch 2 times, most recently from 6fb16f4 to 5887ade Compare November 23, 2023 04:51

hariharan-devarajan marked this pull request as ready for review November 23, 2023 04:56

hariharan-devarajan force-pushed the cmake_refactor branch 2 times, most recently from 9037361 to b6fa11e Compare November 23, 2023 05:15

fix ci

06da6ea

hariharan-devarajan force-pushed the cmake_refactor branch from b6fa11e to 06da6ea Compare November 23, 2023 05:24

hariharan-devarajan reviewed Nov 28, 2023

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

hariharan-devarajan reviewed Dec 1, 2023

View reviewed changes

CMake/dyad-config.cmake.build.in Show resolved Hide resolved

hariharan-devarajan reviewed Dec 1, 2023

View reviewed changes

CMake/dyad-config.cmake.build.in Outdated Show resolved Hide resolved

hariharan-devarajan reviewed Dec 1, 2023

View reviewed changes

CMake/dyad-config.cmake.build.in Outdated Show resolved Hide resolved

hariharan-devarajan reviewed Dec 1, 2023

View reviewed changes

CMake/dyad-config.cmake.install.in Outdated Show resolved Hide resolved

hariharan-devarajan force-pushed the cmake_refactor branch 2 times, most recently from 623b3f3 to 377313f Compare December 1, 2023 07:03

separate setup of spack

1619e2f

hariharan-devarajan force-pushed the cmake_refactor branch from 377313f to 1619e2f Compare December 1, 2023 07:20

hariharan-devarajan added 6 commits December 1, 2023 07:49

fix comments

7603a03

fixed spack script

d0f63d3

fixed python

e373223

Update compile_test.yaml

46a6179

Update compile_test.yaml

7349c59

Update compile_test.yaml

179e18d

ilumsden mentioned this pull request Dec 13, 2023

Adds optimizations to the UCX DTL to improve performance #58

Closed

ilumsden commented Dec 14, 2023

View reviewed changes

src/dyad/core/CMakeLists.txt Outdated Show resolved Hide resolved

src/dyad/dtl/CMakeLists.txt Show resolved Hide resolved

src/dyad/core/CMakeLists.txt Outdated Show resolved Hide resolved

src/dyad/modules/CMakeLists.txt Outdated Show resolved Hide resolved

Changes to public header and libnames

c7d739c

1. Removed dyad_code from public headers 2. used PROJECT_NAME variable for all code 3. prefixed PROJECT_NAME for util code to avoid conflicts

hariharan-devarajan force-pushed the cmake_refactor branch from 904d89c to c7d739c Compare December 15, 2023 03:58

remove variables which prevent cmakr_install.cmake to use CMAKE_INSTA…

6c8b5f5

…LL_PREFIX

Merge branch 'main' of github.com:flux-framework/dyad into cmake_refa…

3fa60de

…ctor � Conflicts: � .github/workflows/compile_test.yaml

JaeseungYeom mentioned this pull request Jan 17, 2024

Pytest fix #62

Closed

JaeseungYeom reviewed Jan 17, 2024

View reviewed changes

hariharan-devarajan added 2 commits January 17, 2024 09:21

fixed typo

069b01f

changed c99 to c11

e0b5d6a

JaeseungYeom merged commit b086558 into main Jan 17, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes the build system to CMake #56

Changes the build system to CMake #56

ilumsden commented Nov 13, 2023

hariharan-devarajan commented Nov 22, 2023

hariharan-devarajan commented Nov 23, 2023 •

edited

Loading

hariharan-devarajan commented Dec 1, 2023

JaeseungYeom commented Jan 13, 2024

JaeseungYeom commented Jan 13, 2024

hariharan-devarajan commented Jan 16, 2024

hariharan-devarajan commented Jan 16, 2024

JaeseungYeom commented Jan 17, 2024

JaeseungYeom commented Jan 17, 2024

hariharan-devarajan commented Jan 17, 2024 •

edited

Loading

JaeseungYeom Jan 17, 2024

hariharan-devarajan Jan 17, 2024

JaeseungYeom Jan 17, 2024

hariharan-devarajan Jan 17, 2024

hariharan-devarajan Jan 17, 2024

Changes the build system to CMake #56

Changes the build system to CMake #56

Conversation

ilumsden commented Nov 13, 2023

hariharan-devarajan commented Nov 22, 2023

hariharan-devarajan commented Nov 23, 2023 • edited Loading

hariharan-devarajan commented Dec 1, 2023

JaeseungYeom commented Jan 13, 2024

JaeseungYeom commented Jan 13, 2024

hariharan-devarajan commented Jan 16, 2024

hariharan-devarajan commented Jan 16, 2024

JaeseungYeom commented Jan 17, 2024

JaeseungYeom commented Jan 17, 2024

hariharan-devarajan commented Jan 17, 2024 • edited Loading

JaeseungYeom Jan 17, 2024

Choose a reason for hiding this comment

hariharan-devarajan Jan 17, 2024

Choose a reason for hiding this comment

JaeseungYeom Jan 17, 2024

Choose a reason for hiding this comment

hariharan-devarajan Jan 17, 2024

Choose a reason for hiding this comment

hariharan-devarajan Jan 17, 2024

Choose a reason for hiding this comment

hariharan-devarajan commented Nov 23, 2023 •

edited

Loading

hariharan-devarajan commented Jan 17, 2024 •

edited

Loading