Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest fix #62

Closed
wants to merge 17 commits into from
Closed

Pytest fix #62

wants to merge 17 commits into from

Conversation

JaeseungYeom
Copy link
Contributor

@JaeseungYeom JaeseungYeom commented Jan 17, 2024 •
edited
Loading

tests/pydyad_spsc seems to have multiple issues.

  1. KVS_NAMESPACE variable is inconsistently used with DYAD_KVS_NAMESPACE
  2. DYAD managed directory is not created.
  3. In case that such a directory already exists, and the directory contains the files from the previous runs, the test is invalid
  4. module load uses producer's managed path which is misleading due to the variable name
  5. Depending on the DTL mode, it shows different errors.

This PR is based on PR #56

@JaeseungYeom JaeseungYeom added the bug Something isn't working label Jan 17, 2024
@JaeseungYeom JaeseungYeom marked this pull request as draft January 17, 2024 18:51
@JaeseungYeom JaeseungYeom force-pushed the pytest_fix branch 2 times, most recently from 8f2ac80 to 6508323 Compare January 18, 2024 00:43
@JaeseungYeom JaeseungYeom deleted the pytest_fix branch January 22, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaeseungYeom @hariharan-devarajan