Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[local_auth_darwin] macOS Support #6267
[local_auth_darwin] macOS Support #6267
Changes from 12 commits
532ed7f
0eb64ee
25ca34e
c57ac02
00bd678
509708f
fd6c539
44dd8c8
4f68b52
8646867
676b0eb
bcee2e7
4aab9d8
1bded66
7335837
849c07b
c810eb4
6867b3a
995f41d
8ab5d09
507470e
05b52ae
8f35101
2b0e6d6
c808c82
64bd0b7
7dab5b4
7ff9871
04f6a76
04c8f12
64366dd
7babc9c
b71f172
cfabac0
5bc080e
d794eb9
74ae648
2374375
f053fce
04049a3
9be16c3
ff533bc
783b0cc
5e9b627
1748039
ebdb5f1
b73254a
c4c9f3b
6ca1476
69db0ec
a39e82a
59ce98a
e54c7ea
b8ca53a
018fe8f
ff38a26
e76f6bc
72b8212
113195e
7525f01
6330a9e
79ebae9
0c84f2b
c84a376
5dc7c75
c33ed13
186d89c
f9e11db
c45084b
7003142
18453dc
fc14107
5840a73
ce1fa37
ad83e24
8beb6dd
067a0c0
e3e89d4
a9167cc
0f56ad6
17bd1c7
2441440
8af7ec7
4fcbc5d
8bd0531
44e5ae3
51b3b02
6d0684f
ca5789f
6d5a0c6
11e6991
316bb68
3728490
5b72aea
6dd9092
b5ea028
dd545e5
85678af
679854a
464ae48
05bc529
d3ce499
57c50d3
860d198
9224412
9c345f9
71a2824
0d420c5
3415984
09236d6
b0de86c
288b04b
23305d0
2293ff6
46ce252
0f7dac8
a91e4e9
e5c9b97
f90387f
9024825
91a6d10
2b2ebab
8c9d1d1
ee97d66
211bc52
fabc0d4
568c0ea
371124c
3b7b5b9
a6a0019
25b6411
5e9af66
a8a4317
c3e81e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/flutter/packages/pull/5766/files#r1486380427
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gist.github.com/rmcdongit/f66ff91e0dad78d4d6346a75ded4b751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've marked this as resolved, but I don't see a code comment in the current version, as requested by the linked review.
More importantly though, what the link you provided appears to be describing is a reverse-engineered system that uses private keys and has a proven track record of fragility to OS updates. That means that:
Am I misunderstanding the discussion there? If not, then this needs a different solution for macOS that is more robust even if it's not as featureful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you suggest then in order to open the settings app? Here is another source with all the url schemes for settings: https://www.mbsplugins.de/archive/2020-04-05/MacOS_System_Preference_Links