[local_auth_darwin] macOS Support #6267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/packages into macos-support
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the contribution! This appears to be very similar to #5766; does this need to be a new PR rather than leaving comments on that one about any suggested changes? |
|
@stuartmorgan That pr doesn't seem to have any momentum and is outdated so I figured I would take this on. |
11 tasks
stuartmorgan
requested changes
Mar 5, 2024
packages/local_auth/local_auth_darwin/example/ios/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
...l_auth/local_auth_darwin/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
Outdated
Show resolved
Hide resolved
packages/local_auth/local_auth_darwin/lib/types/auth_messages_darwin.dart
Outdated
Show resolved
Hide resolved
packages/local_auth/local_auth_darwin/example/macos/RunnerTests/RunnerTests.swift
Outdated
Show resolved
Hide resolved
added 7 commits
March 5, 2024 13:44
…uthMessages This reverts commit 676b0eb.
stuartmorgan
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
I've done the remaining cleanup, and added basic testing of the dialog display for both macOS and iOS.
@LouiseHsu this is ready for final review.
LouiseHsu
approved these changes
Jul 31, 2024
packages/local_auth/local_auth_darwin/darwin/Tests/FLALocalAuthPluginTests.swift
Outdated
Show resolved
Hide resolved
stuartmorgan
changed the title
stuartmorgan
added
the
autosubmit
|
auto label is removed for flutter/packages/6267, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan
added
the
autosubmit
|
auto label is removed for flutter/packages/6267, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan
added
the
autosubmit
|
auto label is removed for flutter/packages/6267, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
(That last failure was just the current macOS host flake we're having, unlike the previous ones.) |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@46a712f...27896d1 2024-08-01 [email protected] [local_auth_darwin] macOS Support (flutter/packages#6267) 2024-08-01 [email protected] Manual roll Flutter from 4d12197 to f817e51 (7 revisions) (flutter/packages#7270) 2024-08-01 [email protected] [ci] version_check_command now checks markdown of first CHANGELOG line. (flutter/packages#7266) 2024-08-01 [email protected] Manual roll Flutter from 031dc3d to 4d12197 (12 revisions) (flutter/packages#7259) 2024-07-31 [email protected] [in_app_purchase_storekit] convert TranslatorTests to swift (flutter/packages#7232) 2024-07-31 [email protected] [google_maps_flutter_web] Migrate to `google_maps: 8.0.0` (flutter/packages#7077) 2024-07-31 [email protected] [tool] Run pre_publish.dart before publish --dry-run (flutter/packages#7258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds macOS support for local_auth_darwin
Cancelled Example:
Success Example
Error Example
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#140685
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.