-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fluent-bit] optional verbosePodLabels to include app.kubernetes.io/version applied to all pods #576
base: main
Are you sure you want to change the base?
Conversation
8fc59e1
to
0f788a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jhulick but as was the case for Metrics Server this isn't a desirable change for the chart. If you make this change optional and off by default I think it would be OK; my preference would be to use a value like verbosePodLabels: false
.
@stevehipwell, I was hesitant to create this PR for that reason, but since fluent-bit is data plane rather than control plane I thought it would be considered acceptable in this case, unless there are other reasons? Is it primarily due to telemetry latency? But I'll update per your proposed suggested. |
460d134
to
aeb9cc3
Compare
@jhulick I don't think the labels are a good idea, but even if they were we'd still be looking to follow the "principal of least astonishment"; so making them opt in is the only real way of introducing this change. |
Signed-off-by: jeremy.hulick <[email protected]>
Signed-off-by: jeremy.hulick <[email protected]>
…nabled in values Signed-off-by: jeremy.hulick <[email protected]>
Signed-off-by: jeremy.hulick <[email protected]>
4e7b751
to
dc8b8bd
Compare
What this PR does / why we need it:
It adds common labels to metadata labels in the pod spec. The main reasoning is to persist the app.kubernetes.io/version and app.kubernetes.io/name labels to the pod for standardization. Per docs, (https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels) "In order to take full advantage of using these labels, they should be applied on every resource object.".
Improves traceability throughout the application. Ex. via Istio/Kiali dashboard.