Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fluent-bit] optional verbosePodLabels to include app.kubernetes.io/version applied to all pods #576

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jhulick
Copy link

@jhulick jhulick commented Dec 9, 2024

What this PR does / why we need it:

  • It adds common labels to metadata labels in the pod spec. The main reasoning is to persist the app.kubernetes.io/version and app.kubernetes.io/name labels to the pod for standardization. Per docs, (https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels) "In order to take full advantage of using these labels, they should be applied on every resource object.".

  • Improves traceability throughout the application. Ex. via Istio/Kiali dashboard.

@jhulick jhulick force-pushed the pod-labels-with-version branch from 8fc59e1 to 0f788a9 Compare December 9, 2024 20:05
@jhulick jhulick changed the title Pod labels with version [fluent-bit] Pod labels include app.kubernetes.io/version Dec 9, 2024
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jhulick but as was the case for Metrics Server this isn't a desirable change for the chart. If you make this change optional and off by default I think it would be OK; my preference would be to use a value like verbosePodLabels: false.

@jhulick
Copy link
Author

jhulick commented Dec 11, 2024

@stevehipwell, I was hesitant to create this PR for that reason, but since fluent-bit is data plane rather than control plane I thought it would be considered acceptable in this case, unless there are other reasons? Is it primarily due to telemetry latency? But I'll update per your proposed suggested.

@jhulick jhulick requested a review from stevehipwell December 11, 2024 19:15
@jhulick jhulick force-pushed the pod-labels-with-version branch from 460d134 to aeb9cc3 Compare December 11, 2024 19:16
@jhulick jhulick changed the title [fluent-bit] Pod labels include app.kubernetes.io/version [fluent-bit] optional verbosePodLabels to include app.kubernetes.io/version applied to all pods Dec 11, 2024
@stevehipwell
Copy link
Collaborator

@jhulick I don't think the labels are a good idea, but even if they were we'd still be looking to follow the "principal of least astonishment"; so making them opt in is the only real way of introducing this change.

@jhulick jhulick force-pushed the pod-labels-with-version branch from 4e7b751 to dc8b8bd Compare December 12, 2024 18:37
@jhulick jhulick requested a review from stevehipwell December 12, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants