Skip to content

Commit

Permalink
changes per peer review comments
Browse files Browse the repository at this point in the history
Signed-off-by: jeremy.hulick <[email protected]>
  • Loading branch information
jhulick committed Dec 12, 2024
1 parent 41f787b commit dc8b8bd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
6 changes: 1 addition & 5 deletions charts/fluent-bit/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ spec:
template:
metadata:
labels:
{{- if .Values.verbosePodLabels.enabled }}
{{- include "fluent-bit.verbosePodLabels" . | nindent 8 }}
{{- else }}
{{- include "fluent-bit.selectorLabels" . | nindent 8 }}
{{- end }}
{{- include (ternary "fluent-bit.verbosePodLabels" "fluent-bit.selectorLabels" .Values.verbosePodLabels) . | nindent 8 }}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
6 changes: 1 addition & 5 deletions charts/fluent-bit/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@ spec:
template:
metadata:
labels:
{{- if .Values.verbosePodLabels.enabled }}
{{- include "fluent-bit.verbosePodLabels" . | nindent 8 }}
{{- else }}
{{- include "fluent-bit.selectorLabels" . | nindent 8 }}
{{- end }}
{{- include (ternary "fluent-bit.verbosePodLabels" "fluent-bit.selectorLabels" .Values.verbosePodLabels) . | nindent 8 }}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
3 changes: 1 addition & 2 deletions charts/fluent-bit/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,7 @@ podAnnotations: {}
podLabels: {}

# adds app.kubernetes.io/version label to pods for istio required labels
verbosePodLabels:
enabled: false
verbosePodLabels: false

## How long (in seconds) a pods needs to be stable before progressing the deployment
##
Expand Down

0 comments on commit dc8b8bd

Please sign in to comment.