Skip to content

ci: Ensure helm tests run on changes to the chart #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions .github/workflows/helm-ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
name: Helm CI

on:
pull_request:
branches:
- 'master'
- 'release-*'
paths:
- ".github/workflows/helm-ci.yaml"
- "charts/**"
- "tests/**"
- "Makefile"
- "go.mod"
- "go.sum"
Comment on lines +9 to +14
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only runs when these files change.


env:
KUBECTL_VERSION: v1.25.1
HELM_VERSION: v3.17.2

jobs:
helm-tests:
name: helm e2e tests
runs-on: ubuntu-22.04

timeout-minutes: 30

env:
GO111MODULE: "on"

steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0

- name: Install Go
uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
with:
go-version-file: go.mod
cache-dependency-path: go.sum

- name: Setup kubectl
uses: marcofranssen/setup-kubectl@d81bf181729cee2bc813ac2ea2f74dec90f01f99 # v1.3.0
with:
kubectlVersion: ${{ env.KUBECTL_VERSION }}

- name: Install Helm
uses: azure/setup-helm@b9e51907a09c216f16ebe8536097933489208112 # v4.3.0
with:
version: ${{ env.HELM_VERSION }}

- name: Install dependences
run: make ginkgo kind

- name: Run helm e2e tests
run: make helm-e2e
34 changes: 0 additions & 34 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,40 +116,6 @@ jobs:
- name: Run e2e tests
run: make e2e

helm_tests:
runs-on: ubuntu-22.04
timeout-minutes: 30
name: helm e2e tests
env:
GO111MODULE: "on"
steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0

- name: Install Go
uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
with:
go-version-file: go.mod
cache-dependency-path: go.sum

- name: Setup kubectl
uses: marcofranssen/setup-kubectl@d81bf181729cee2bc813ac2ea2f74dec90f01f99 # v1.3.0
with:
kubectlVersion: ${{ env.KUBECTL_VERSION }}

- name: Install Helm
uses: azure/setup-helm@b9e51907a09c216f16ebe8536097933489208112 # v4.3.0
with:
version: ${{ env.HELM_VERSION }}

- name: Install dependences
run: make ginkgo kind

- name: Run helm e2e tests
run: make helm-e2e
Comment on lines -119 to -151
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't depend on other jobs so no need to be in same workflow (allowing for more finegrained control when this part runs see above comment.


build:
runs-on: ubuntu-22.04
timeout-minutes: 30
Expand Down