ci: Ensure helm tests run on changes to the chart #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
commented
Apr 30, 2025
Comment on lines
+9
to
+14
| - ".github/workflows/helm-ci.yaml" | ||
| - "charts/**" | ||
| - "tests/**" | ||
| - "Makefile" | ||
| - "go.mod" | ||
| - "go.sum" |
There was a problem hiding this comment.
Only runs when these files change.
marcofranssen
commented
Apr 30, 2025
Comment on lines
-119
to
-151
| helm_tests: | ||
| runs-on: ubuntu-22.04 | ||
| timeout-minutes: 30 | ||
| name: helm e2e tests | ||
| env: | ||
| GO111MODULE: "on" | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0 | ||
| with: | ||
| go-version-file: go.mod | ||
| cache-dependency-path: go.sum | ||
|
|
||
| - name: Setup kubectl | ||
| uses: marcofranssen/setup-kubectl@d81bf181729cee2bc813ac2ea2f74dec90f01f99 # v1.3.0 | ||
| with: | ||
| kubectlVersion: ${{ env.KUBECTL_VERSION }} | ||
|
|
||
| - name: Install Helm | ||
| uses: azure/setup-helm@b9e51907a09c216f16ebe8536097933489208112 # v4.3.0 | ||
| with: | ||
| version: ${{ env.HELM_VERSION }} | ||
|
|
||
| - name: Install dependences | ||
| run: make ginkgo kind | ||
|
|
||
| - name: Run helm e2e tests | ||
| run: make helm-e2e |
There was a problem hiding this comment.
didn't depend on other jobs so no need to be in same workflow (allowing for more finegrained control when this part runs see above comment.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures PRs, like this will run the helm ci
#1585
Moved it out of the main workflow so it doesn't affect running other workflows that shouldn't be required so we can have bit more finegraining on the paths.