filter_log_to_metrics: Add interval options for metric emission #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Treu <[email protected]>
4 tasks
There was a problem hiding this comment.
thanks for submitting a PR, @drbugfinder-work! I've made a few suggestions in accordance with our style guide, and then there's just one question I wanted to clarify about the behavior of Interval_Sec vs Interval_Nsec 🙂
Thanks @alexakreizinger Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Richard Treu <[email protected]>
Thanks @alexakreizinger Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Richard Treu <[email protected]>
alexakreizinger
approved these changes
Aug 20, 2024
Signed-off-by: Richard Treu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.