filter_log_to_metrics: Add timer callback for emitting metrics #9251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbugfinder-work
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
leonardo-albertovich
requested changes
Aug 20, 2024
There was a problem hiding this comment.
I like the idea of adding the option to the plugin to keep a metrics context and periodically flush it but I don't think imposing it as the new default behavior is acceptable.
Please restore the original "immediate flush" code and modify your code to select between immediate and delayed flushing (maybe by defaulting the value of timer_interval_ms to 0 and interpretting 0 as immediate?).
Also, please rename timer_interval_ms to something more intuitive like flush_interval and use the FLB_CONFIG_MAP_TIME type instead (which automatically interprets units and makes it easier for the user).
drbugfinder-work
force-pushed
the
log_to_metrics_timer
branch
from
4d9ee65
to
ccf20e5
Compare
drbugfinder-work
force-pushed
the
log_to_metrics_timer
branch
from
ccf20e5
to
c6d7766
Compare
|
Hi @leonardo-albertovich! fluent-bit/plugins/filter_multiline/ml.c Line 894 in 8a1d830 Can you please check the changes? Thank you very much! |
leonardo-albertovich
requested changes
Aug 20, 2024
This commit will change the log_to_metrics filter to use a timer based metric inject and not directly inject metrics on every incoming log record anymore. This will lower the overall load and memory consumption especially in high-volume and high-cardinality situations. Signed-off-by: Richard Treu <[email protected]>
drbugfinder-work
force-pushed
the
log_to_metrics_timer
branch
from
c6d7766
to
b22acf7
Compare
Thank you very much @leonardo-albertovich! |
|
Docs PR: fluent/fluent-bit-docs#1440 |
leonardo-albertovich
approved these changes
Aug 20, 2024
|
(cc: docs @lecaros ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the log_to_metrics filter to use a timer based metric inject and not directly inject metrics on every incoming log record anymore. This will lower the overall load and memory consumption especially in high-volume and high-cardinality situations.
cc @leonardo-albertovich @edsiper
Fixes #9189
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
filter_log_to_metrics: Add interval options for metric emission fluent-bit-docs#1440
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.