Windows: fixes #288
Open
Windows: fixes #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Closed
|
ghost
commented
Oct 25, 2017
runtime/flang/const.c
Outdated
| @@ -133,7 +133,7 @@ __INT_T ENTCOMN(TYPE, type)[] = { | |||
| 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, | |||
| 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43}; | |||
|
|
|||
| #if defined(WINNT) && !defined(WIN64) && !defined(WIN32) | |||
| #ifdef _WIN32 | |||
|
@sscalpone Do you know where the |
|
See my comments on #287. |
isuruf
reviewed
Oct 26, 2017
| @@ -32,3 +32,4 @@ build_script: | |||
| - ps: | | |||
| cmake --build . 2>&1 | Out-File build_output.txt | |||
| Push-AppveyorArtifact .\build_output.txt | |||
| if($LastExitCode -ne 0) { $host.SetShouldExit($LastExitCode ) } | |||
There was a problem hiding this comment.
Isn't this checking the error code of Push-AppveyorArtifact?
|
@sscalpone Can we schedule a slack time? |
|
I've just opened a pull request at flang-compiler/clang#37 that applies additional changes to the compiler driver. These changes add additional linker arguments so that the correct runtime libraries are linked. Calling so there are still some basic symbols missing. If I take a look at After these symbol errors would be resolved, I would start to look into making the test-suite work on windows, so that we can get a clearer image of what is really working and what is not. |
|
|
|
It was a missing Now the executable links successfully but does not produce any output when being executed. I will dig deeper into that! |
|
I compiled a hello world application yesterday and linked to the static libs manually. Hello world was printed and then there was a crash. |
|
I can reproduce the same behavior when linking to the static flang runtime. |
|
PGI does export-all for the libraries. |
|
@sscalpone Can you answer my question on #287? |
|
So I think we removed the signal handlers because they don't work with MSVC. I'm going to attempt to install a signal handler that will work for us. |
|
I don't know which of the above incremental changes fixed it for me, but a simple hello world works as intended now. Hooray! Couple of issues, isuruf#15 (review) |
|
We also need to get the tests working so that we have some idea of where we are. |
|
@xoviat, conda package is available in my channel |
|
Okay. |
|
Using the latest conda package from this I haven't been able to get a minimal working example yet because things like |
|
Got it. That makes sense. Is there some way to get around needing to run that command on |
|
Don't use the ninja generator. Use the nmake makefiles generator. |
|
Thanks. Good find. A minimal hello world example is working with CMake for me. I'm using NMake in the MSVC 2015 native x64 terminal and had to set the |
|
Try to compile OpenBLAS with DYNAMIC_ARCH. |
|
That also configures correctly. Compilation will take a while. |
This was because the static and shared libraries were both producing .mod files at the same location and a parallel build was confusing the compiler with the timestamps
The CMake Ninja generator requires the "use" statement to declare dependnecies rather than the "use, instrinsic" statement. Since we're bootsrapping, the "intrinsic" makes no functional difference and leads to race conditions.
CMake: Fix warnings
Pull recent NVIDIA changes
CMake handles module dependencies now that flang -E works
Pull recent NVIDIA changes
Pull recent NVIDIA changes
Pull recent NVIDIA changes
Pull recent NVIDIA changes
Pull recent NVIDIA changes
Pull recent NVIDIA changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.