rename direct header to avoid windows conflict

[xoviat]

No description provided.

[xoviat]

cc @kiranchandramohan

[kiranchandramohan]

LGTM. Thanks for this patch. There is some renewed interest in supporting windows.

Can you add a bit more info to the commit message, like for e.g. "direct.h is a system header in windows providing functions for manipulating filesystem directories"?

Merge process requires someone to test on Aarch64 and X86_64. So will need approval from @shivaramaarao. And because we do not have windows machines at least one member from the windows community to approve. Have added @isuruf, also checking with another person whether he can help review from the windows side.

[kaadam]

Yes, direct header is one of C run time libraries on Windows, so it needs to rename it. LGTM (from Windows side).

[xoviat]

Note: the only windows person you need approval from is me because I am the person who has flang working on windows. But isuruf can vouch for me.

[kiranchandramohan]

Thanks @xoviat for the clarification.

@kaadam is also working on windows support in flang, and I think he has also got it working. I believe he has his own patches and some from #464. He is also interested in upstreaming. I believe he has some questions on how to co-ordinate.

[kaadam]

@xoviat we're also working on Windows support of Flang. We managed to build Flang on Windows X64, and compile some small example with it. For that we applied some changes from @isuruf / #288 / and extend them with ours. Our aims is also upstream our fixes if it doesn't conflict with your PRs @xoviat.

[xoviat]

@kaadam Do you have a github branch? You can see what I have at https://github.com/xoviat/flang/tree/windows. The only addition I made was to add a driver so that I don't have to build a custom clang.

[xoviat]

Obviously I cannot just submit the entire patch at once, which is why I am submitting patches from a different branch.

[kaadam]

@xoviat Yes, here it is my WIP branch, it is a draft: https://github.com/kaadam/flang/tree/windows
All in all I can help to test or review changes, if it is necessary.

[xoviat]

I updated the commit message. @kaadam I will continue to submit PRs, and you can review them for compatibility with your changes.

[bryanpkc]

LGTM. Thanks!

[kaadam]

@kiranchandramohan @bryanpkc Are we waiting for one more approval, or could we land this?

[kiranchandramohan]

We require approval from @shivaramaarao for x86_64.