Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split apart the index argument to the replace_subject,trial,test functions into idx_new and idx_out #395

Merged
merged 12 commits into from
Jul 26, 2023
Merged

Split apart the index argument to the replace_subject,trial,test functions into idx_new and idx_out #395

merged 12 commits into from
Jul 26, 2023

Commits on Jul 25, 2023

  1. start tidying indexing for replace_* fml functions

    @JHopeCollins
    JHopeCollins committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1a25a5d View commit details
    Browse the repository at this point in the history

  2. correct replace if statements

    @JHopeCollins
    JHopeCollins committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2d2fe98 View commit details
    Browse the repository at this point in the history

  3. parameterized replace test

    @JHopeCollins
    JHopeCollins committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d1de427 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. remove old _replace_dict method and flake8

    @JHopeCollins
    JHopeCollins committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9ac02e2 View commit details
    Browse the repository at this point in the history

  2. new replace_subject tests

    @JHopeCollins
    JHopeCollins committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b3b0f4a View commit details
    Browse the repository at this point in the history

  3. correct replace_subject calls in tests and gusto

    @JHopeCollins
    JHopeCollins committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    79f9650 View commit details
    Browse the repository at this point in the history

  4. we do need the old index for test and trial functions

    @jshipton
    jshipton committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    27f2f3c View commit details
    Browse the repository at this point in the history

  5. add tests for replacing test and trial functions

    @jshipton
    jshipton committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ca840e3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'JHopeCollins/indexed_replace' of https://github.com/fir… 

    …edrakeproject/gusto into JHopeCollins/indexed_replace
    @jshipton
    jshipton committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9243115 View commit details
    Browse the repository at this point in the history

  7. fix lint

    @jshipton
    jshipton committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4c8592d View commit details
    Browse the repository at this point in the history

  8. rename file

    @jshipton
    jshipton committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    af4f6c8 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'restructure_fml' into JHopeCollins/indexed_replace

    @jshipton
    jshipton committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    172ee74 View commit details
    Browse the repository at this point in the history