Split apart the index argument to the replace_subject,trial,test functions into idx_new and idx_out
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshipton
reviewed
Jul 25, 2023
jshipton
reviewed
Jul 25, 2023
jshipton
reviewed
Jul 25, 2023
…edrakeproject/gusto into JHopeCollins/indexed_replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
replace_*functions previously only accepted a single index argument. If only one of the new/old things were indexable (i.e. a mixed space or a tuple) then the index was used for that one. If both were indexable then the index was used for both. If neither was indexable then it was silently ignored. This is error prone because the index argument can mean different things depending on the other arguments, and it is silently ignored rather than warning/erroring when it isn't used.This PR changes the
replace_*functions to take separateold_idxandnew_idxfor indexing the thing being replaced (old) or the thing replacing (new). They will also error if an index is given but not used.